TYP: io.pytables annotations #29861
Merged
TYP: io.pytables annotations #29861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updated with a few more annotations broken off from other branches |
…n-pytables-types
…n-pytables-types
…n-pytables-types
|
@jbrockmendel can you resolve conflicts |
…n-pytables-types
|
rebased+green |
WillAyd
reviewed
Nov 29, 2019
| self, parent: HDFStore, group: "Node", encoding=None, errors="strict", **kwargs | ||
| ): | ||
| assert isinstance(parent, HDFStore), type(parent) | ||
| assert _table_mod is not None # needed for mypy |
There was a problem hiding this comment.
Does this not have any impact on runtime? The global state management here is a little nuanced so just want to double check that it is valid to add to the constructor here, as on first glance it may not be set until methods are called by design
There was a problem hiding this comment.
It does not, we wouldn't get here if _table_mod were not initialized
|
thanks |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.