-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TYP: io.pytables annotations #29861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
TYP: io.pytables annotations #29861
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0498a8e
types
jbrockmendel aa01763
remove unnecessary kwarg
jbrockmendel 00d8760
type index
jbrockmendel 84b03bd
move assertion earlier and remove type ignore
jbrockmendel 74dfa0a
more types
jbrockmendel fc05f51
one more
jbrockmendel d1206c5
Merge branch 'master' of https://github.com/pandas-dev/pandas into cl…
jbrockmendel 18ef688
Merge branch 'master' of https://github.com/pandas-dev/pandas into cl…
jbrockmendel 31c9940
Merge branch 'master' of https://github.com/pandas-dev/pandas into cl…
jbrockmendel eb66c91
Merge branch 'master' of https://github.com/pandas-dev/pandas into cl…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not have any impact on runtime? The global state management here is a little nuanced so just want to double check that it is valid to add to the constructor here, as on first glance it may not be set until methods are called by design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not, we wouldn't get here if _table_mod were not initialized