Skip to content

CI: use conda incubator in benchmarks #39043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 14, 2021

Conversation

fangchenli
Copy link
Member

The benchmark ci currently has the longest runtime. Using conda incubator would save about 6-8 min.

@fangchenli fangchenli added the CI Continuous Integration label Jan 8, 2021
@jorisvandenbossche
Copy link
Member

@fangchenli this looks like a nice clean-up in any case (thanks!), but how would it save 6-8 minutes? (it currently does not seem to take less time as on master, unless the caching is not yet working here in this PR?)

@fangchenli
Copy link
Member Author

@fangchenli this looks like a nice clean-up in any case (thanks!), but how would it save 6-8 minutes? (it currently does not seem to take less time as on master, unless the caching is not yet working here in this PR?)

My mistake... It's more like 3 minutes. The caching is not working in this PR (maybe it doesn't work on PRs?). The two database builds are using conda incubator currently. It takes less time to setup the environment on those two builds. So I think caching is working there.

@jreback
Copy link
Contributor

jreback commented Jan 12, 2021

caching is only enabled in the master branch pushes

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weirdly the doc build is failing

@fangchenli
Copy link
Member Author

fangchenli commented Jan 13, 2021

weirdly the doc build is failing

doc/make.py --warnings-are-errors | tee sphinx.log ; exit ${PIPESTATUS[0]}

PIPESTATUS[0] is 1 now. Not sure why. Looking at the output of doc/make.py --warnings-are-errors, nothing is failing.

update

I missed this error.

>>>-------------------------------------------------------------------------
Exception in /home/runner/work/pandas/pandas/doc/source/whatsnew/v0.8.0.rst at block ending on line 201
Specify :okexcept: as an option in the ipython:: block to suppress this message
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-2-65b822729fc4> in <module>
----> 1 plt.figure()

NameError: name 'plt' is not defined
<<<-------------------------------------------------------------------------

@jreback
Copy link
Contributor

jreback commented Jan 14, 2021

maybe the doc build is not picking up the correct file / deps as it is in master?

@fangchenli
Copy link
Member Author

maybe the doc build is not picking up the correct file / deps as it is in master?

I fixed the error mentioned above. Right now the outputs of doc/make.py --warnings-are-errors of this PR is identical to master's. Only the exit codes are different.

@fangchenli fangchenli changed the title CI: use conda incubator in doc and benchmarks CI: use conda incubator in benchmarks Jan 14, 2021
@fangchenli
Copy link
Member Author

I'll revert the doc build and open an issue for it.

@jreback jreback added this to the 1.3 milestone Jan 14, 2021
@jreback jreback merged commit 76701a6 into pandas-dev:master Jan 14, 2021
@jreback
Copy link
Contributor

jreback commented Jan 14, 2021

thanks @fangchenli

@@ -176,7 +176,7 @@ New plotting methods
Vytautas Jancauskas, the 2012 GSOC participant, has added many new plot
types. For example, ``'kde'`` is a new option:

.. ipython:: python
.. code-block:: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fangchenli do you remember why you needed to make this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It caused an error while using incubator. But I didn't get the incubator to work for the doc build. I probably should revert it as well.

>>>-------------------------------------------------------------------------
Exception in /home/runner/work/pandas/pandas/doc/source/whatsnew/v0.8.0.rst at block ending on line 201
Specify :okexcept: as an option in the ipython:: block to suppress this message
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-2-65b822729fc4> in <module>
----> 1 plt.figure()

NameError: name 'plt' is not defined
<<<-------------------------------------------------------------------------

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@fangchenli fangchenli deleted the conda-incubator-ci branch March 18, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants