-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: use conda incubator in benchmarks #39043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@fangchenli this looks like a nice clean-up in any case (thanks!), but how would it save 6-8 minutes? (it currently does not seem to take less time as on master, unless the caching is not yet working here in this PR?) |
My mistake... It's more like 3 minutes. The caching is not working in this PR (maybe it doesn't work on PRs?). The two database builds are using conda incubator currently. It takes less time to setup the environment on those two builds. So I think caching is working there. |
caching is only enabled in the master branch pushes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weirdly the doc build is failing
updateI missed this error. >>>-------------------------------------------------------------------------
Exception in /home/runner/work/pandas/pandas/doc/source/whatsnew/v0.8.0.rst at block ending on line 201
Specify :okexcept: as an option in the ipython:: block to suppress this message
---------------------------------------------------------------------------
NameError Traceback (most recent call last)
<ipython-input-2-65b822729fc4> in <module>
----> 1 plt.figure()
NameError: name 'plt' is not defined
<<<------------------------------------------------------------------------- |
maybe the doc build is not picking up the correct file / deps as it is in master? |
I fixed the error mentioned above. Right now the outputs of |
I'll revert the doc build and open an issue for it. |
thanks @fangchenli |
@@ -176,7 +176,7 @@ New plotting methods | |||
Vytautas Jancauskas, the 2012 GSOC participant, has added many new plot | |||
types. For example, ``'kde'`` is a new option: | |||
|
|||
.. ipython:: python | |||
.. code-block:: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fangchenli do you remember why you needed to make this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It caused an error while using incubator. But I didn't get the incubator to work for the doc build. I probably should revert it as well.
>>>-------------------------------------------------------------------------
Exception in /home/runner/work/pandas/pandas/doc/source/whatsnew/v0.8.0.rst at block ending on line 201
Specify :okexcept: as an option in the ipython:: block to suppress this message
---------------------------------------------------------------------------
NameError Traceback (most recent call last)
<ipython-input-2-65b822729fc4> in <module>
----> 1 plt.figure()
NameError: name 'plt' is not defined
<<<-------------------------------------------------------------------------
The benchmark ci currently has the longest runtime. Using conda incubator would save about 6-8 min.