Skip to content

CI: use conda incubator in benchmarks #39043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 14, 2021
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 67 additions & 39 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: CI

on:
push:
branches: master
branches: [master]
pull_request:
branches:
- master
Expand All @@ -15,61 +15,70 @@ jobs:
checks:
name: Checks
runs-on: ubuntu-latest
steps:

- name: Setting conda path
run: echo "${HOME}/miniconda3/bin" >> $GITHUB_PATH
defaults:
run:
shell: bash -l {0}

steps:
- name: Checkout
uses: actions/checkout@v1

- name: Looking for unwanted patterns
run: ci/code_checks.sh patterns
if: always()

- name: Setup environment and build pandas
run: ci/setup_env.sh
if: always()
- name: Cache conda
uses: actions/cache@v1
env:
CACHE_NUMBER: 0
with:
path: ~/conda_pkgs_dir
key: ${{ runner.os }}-conda-${{ env.CACHE_NUMBER }}-${{
hashFiles('${{ env.ENV_FILE }}') }}

- name: Linting
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: pandas-dev
channel-priority: strict
environment-file: ${{ env.ENV_FILE }}
use-only-tar-bz2: true

- name: Environment Detail
run: |
source activate pandas-dev
ci/code_checks.sh lint
conda info
conda list

- name: Build Pandas
run: |
python setup.py build_ext -j 2
python -m pip install -e . --no-build-isolation --no-use-pep517

- name: Linting
run: ci/code_checks.sh lint
if: always()

- name: Checks on imported code
run: |
source activate pandas-dev
ci/code_checks.sh code
run: ci/code_checks.sh code
if: always()

- name: Running doctests
run: |
source activate pandas-dev
ci/code_checks.sh doctests
run: ci/code_checks.sh doctests
if: always()

- name: Docstring validation
run: |
source activate pandas-dev
ci/code_checks.sh docstrings
run: ci/code_checks.sh docstrings
if: always()

- name: Typing validation
run: |
source activate pandas-dev
ci/code_checks.sh typing
run: ci/code_checks.sh typing
if: always()

- name: Testing docstring validation script
run: |
source activate pandas-dev
pytest --capture=no --strict-markers scripts
run: pytest --capture=no --strict-markers scripts
if: always()

- name: Running benchmarks
run: |
source activate pandas-dev
cd asv_bench
asv check -E existing
git remote add upstream https://github.com/pandas-dev/pandas.git
Expand All @@ -91,26 +100,45 @@ jobs:
web_and_docs:
name: Web and docs
runs-on: ubuntu-latest
steps:

- name: Setting conda path
run: echo "${HOME}/miniconda3/bin" >> $GITHUB_PATH
defaults:
run:
shell: bash -l {0}

steps:
- name: Checkout
uses: actions/checkout@v1

- name: Setup environment and build pandas
run: ci/setup_env.sh
- name: Cache conda
uses: actions/cache@v1
env:
CACHE_NUMBER: 0
with:
path: ~/conda_pkgs_dir
key: ${{ runner.os }}-conda-${{ env.CACHE_NUMBER }}-${{
hashFiles('${{ env.ENV_FILE }}') }}

- name: Build website
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: pandas-dev
channel-priority: strict
environment-file: ${{ env.ENV_FILE }}
use-only-tar-bz2: true

- name: Environment Detail
run: |
source activate pandas-dev
python web/pandas_web.py web/pandas --target-path=web/build
conda info
conda list

- name: Build documentation
- name: Build Pandas
run: |
source activate pandas-dev
doc/make.py --warnings-are-errors | tee sphinx.log ; exit ${PIPESTATUS[0]}
python setup.py build_ext -j 2
python -m pip install -e . --no-build-isolation --no-use-pep517

- name: Build website
run: python web/pandas_web.py web/pandas --target-path=web/build

- name: Build documentation
run: doc/make.py --warnings-are-errors | tee sphinx.log ; exit ${PIPESTATUS[0]}

# This can be removed when the ipython directive fails when there are errors,
# including the `tee sphinx.log` in te previous step (https://github.com/ipython/ipython/issues/11547)
Expand Down