DOC add example to reorder levels #42935
Conversation
Response to changes suggested on my previous pull request
|
Hello @trevorkask! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-23 15:16:42 UTC |
There was a problem hiding this comment.
Have you tried building the docs to check this looks right?
https://pandas.pydata.org/pandas-docs/stable/development/contributing_documentation.html
|
Are you going to close #42667 or this? You should really continue that PR and close this one. |
Fixed the indentation issue
pandas/core/frame.py
Outdated
| """ | ||
| Examples | ||
| -------- |
There was a problem hiding this comment.
This won't render, it needs to be inside the docstring
pandas/core/frame.py
Outdated
| 'species':['Humans','Dogs','Snakes','Iguanas','Frogs','Aquatic Salamanders'] | ||
| } | ||
| >>> df=pd.DataFrame(data,columns=['class','diet','species']) | ||
| >>> df.set_index(['class','diet'],drop=True,inplace=True) |
There was a problem hiding this comment.
can you write this without using inplace=True please?
|
use this one |
Built the example inside the docstring and removed the unnecessary inplace=true
There was a problem hiding this comment.
Hi @trevorkask - the example looks good, there's just some stylistic errors
Can you fix them up? See https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html?highlight=pre%20commit#pre-commit
|
Thanks @trevorkask |
* Update frame.py Response to changes suggested on my previous pull request * Update frame.py Fixed the indentation issue * Update frame.py Built the example inside the docstring and removed the unnecessary inplace=true * fixup Co-authored-by: Marco Gorelli <[email protected]>
Response to changes suggested on my previous pull request