Skip to content

Add example #43032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add example #43032

wants to merge 5 commits into from

Conversation

madhuri-15
Copy link
Contributor

Add example to reorder_levels function of Pandas DataFrame

@pep8speaks
Copy link

pep8speaks commented Aug 14, 2021

Hello @madhuri-15! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 6818:14: W291 trailing whitespace
Line 6828:14: W291 trailing whitespace
Line 6840:79: W291 trailing whitespace
Line 6848:75: W291 trailing whitespace
Line 6854:14: W291 trailing whitespace
Line 6868:14: W291 trailing whitespace
Line 6877:14: W291 trailing whitespace
Line 6906:84: W291 trailing whitespace

Comment last updated at 2021-08-15 11:29:15 UTC

@attack68
Copy link
Contributor

reorder_levels seems to break a lexsort. Can it be documented how to reorder and maintain the lexsorted property, i.e. by calling a sort method.

As a follow-on it might be worth proposing an issue to add a sort keyword arg to the method so that it can sort if necessary.

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Aug 15, 2021

This looks duplicative of #42935 , which was opened first - let's close in favour of that one for the time being, we can come back to this if that one goes stale - thanks anyway for your PR, and sorry to do this

@madhuri-15 madhuri-15 deleted the add-example branch August 15, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants