-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Rolling rank #43338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ENH: Rolling rank #43338
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3ebf8c0
ENH: rolling rank
gsiano ce754f7
ENH: rolling rank
gsiano f13a720
Merge branch 'rolling_rank' of github.com:gsiano/pandas into rolling_…
gsiano 874c980
ENH: rolling rank
gsiano 4d06ba3
ENH: rolling rank
gsiano 1308208
ENH: rolling rank
gsiano 4caa51b
ENH: rolling rank
gsiano f2ee5b2
ENH: rolling rank - rank methods
gsiano b135f1e
ENH: rolling rank - `ascending` flag
gsiano fda85b4
ENH: rolling rank
gsiano e692ce3
ENH: rolling rank - reorder parameter list
gsiano 6b23fc0
ENH: rolling rank - address pre-commit errors
gsiano 5f7d319
ENH: rolling rank
gsiano 63d37c5
ENH: rolling rank - fix pre-commit errors
gsiano ba468c6
ENH: rolling rank
gsiano e078119
Merge branch 'master' into rolling_rank
gsiano bb7005f
ENH: rolling rank
gsiano 1470c7b
ENH: rolling rank
gsiano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1500,3 +1500,25 @@ def test_rolling_numeric_dtypes(): | |
dtype="float64", | ||
) | ||
tm.assert_frame_equal(result, expected) | ||
|
||
|
||
@pytest.mark.parametrize("window", [1, 3, 10, 1000]) | ||
def test_rank(window): | ||
length = 1000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
ser = Series(data=np.random.rand(length)) | ||
|
||
expected = ser.rolling(window).apply(lambda x: x.rank().iloc[-1]) | ||
result = ser.rolling(window).rank() | ||
|
||
tm.assert_series_equal(result, expected) | ||
|
||
|
||
@pytest.mark.parametrize("window", [1, 3, 10, 1000]) | ||
def test_percentile_rank(window): | ||
length = 1000 | ||
ser = Series(data=np.random.rand(length)) | ||
|
||
expected = ser.rolling(window).apply(lambda x: x.rank(pct=True).iloc[-1]) | ||
result = ser.rolling(window).rank(pct=True) | ||
|
||
tm.assert_series_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NBD since doesn't affect correctness, but I find this clearer since
None
initialization usually used only when there's a path where the variable might not end up initialized. Also generates a bit less code :)