BUG: Categorical of booleans has object .categories #46422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
changed the title
jreback
added
Dtype Conversions
jreback
requested changes
Mar 19, 2022
pandas/tests/dtypes/test_dtypes.py
Outdated
| ) | ||
| value = df["bool_cat"].cat.categories.dtype | ||
| expected = np.dtype(np.bool_) | ||
| not_expected = np.dtype(np.object_) |
There was a problem hiding this comment.
you don't need the not expected case
pandas/tests/dtypes/test_dtypes.py
Outdated
| def test_categorical_of_booleans_is_boolean(): | ||
| # https://github.com/pandas-dev/pandas/issues/46313 | ||
| df = pd.DataFrame( | ||
| {"int_cat": [1, 2, 3], "bool_cat": [True, False, False]}, dtype="category" |
There was a problem hiding this comment.
move to pandas/tests/series/accessors/test_cat_accessor.py
|
Hi there, I moved the code to the specified location and removed the unnecessary line. Thanks for giving feedback! |
jreback
approved these changes
Mar 20, 2022
mroeschke
approved these changes
Mar 20, 2022
|
Thanks @rxd330 |
4 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TST: tests added pre GH46313 * Revert "TST: tests added pre GH46313" This reverts commit a5a0a29. * TST:test added for GH46313 * file reformated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This patch adds a test for checking regression behavior as described in #46313. The bug was reported to be fixed and I could not reproduce the bug in the latest version as Mar.18, 2022. So, only a test was added.
This is my first contribution to the open-source project. Please let me know if something needs to be fixed. Thanks!