Skip to content

BUG: Categorical of booleans has object .categories #46422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2022
Merged

BUG: Categorical of booleans has object .categories #46422

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5a0a29
TST: tests added pre GH46313
rxd330 Mar 18, 2022
55ca0e0
Revert "TST: tests added pre GH46313"
rxd330 Mar 18, 2022
b9923cd
TST:test added for GH46313
rxd330 Mar 18, 2022
9fac111
file reformated
rxd330 Mar 20, 2022
dcce22d
Merge branch 'main' into test_for_gh46313
rxd330 Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pandas/tests/dtypes/test_dtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,3 +1107,15 @@ def test_compare_complex_dtypes():

with pytest.raises(TypeError, match=msg):
df.lt(df.astype(object))


def test_categorical_of_booleans_is_boolean():
# https://github.com/pandas-dev/pandas/issues/46313
df = pd.DataFrame(
{"int_cat": [1, 2, 3], "bool_cat": [True, False, False]}, dtype="category"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to pandas/tests/series/accessors/test_cat_accessor.py

)
value = df["bool_cat"].cat.categories.dtype
expected = np.dtype(np.bool_)
not_expected = np.dtype(np.object_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the not expected case

assert value is expected
assert value is not not_expected