Backport PR #47550 on branch 1.4.x (REGR: fix eval with inplace=True to correctly update column values inplace) #48151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place (pandas-dev#47550) * fix pre-commit issues * fix linting errors * add inplace argument to isetitem and use in eval * changes due to PR discussions * fix issues * update eval * update whatsnew * add PR suggestions * update imports in eval.py * check inplace and use NDFrame + small update to test * update test to use using_copy_on_write * skip test for array manager Co-authored-by: Joris Van den Bossche <[email protected]>
phofl
added
Regression
phofl
changed the title
simonjayhawkins
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47550