TST: Added test for groupby dropping NA when grouping on columns #50156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbhoopala
changed the title
phofl
reviewed
Dec 11, 2022
pandas/tests/groupby/test_groupby.py
Outdated
| {"a": [np.nan, "foo", "bar", np.nan, np.nan, "baz"], "b": [0, 1, 2, 3, 4, 5]} | ||
| ) | ||
| result = df.groupby("a").head(1) | ||
| expected = DataFrame({"a": ["foo", "bar", "baz"], "b": [1, 2, 5]}) |
There was a problem hiding this comment.
Can you define the index in here as well? No need to set in an extra line.
Also please merge main
There was a problem hiding this comment.
I just added a commit which defines the index in the DataFrame constructor, as requested. Also, I have merged the pull request to main.
rhshadrach
requested changes
Dec 13, 2022
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Closing as stale. @pbhoopala - if you're interested in continuing just comment here and happy to reopen. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.