TST: Test groupby method drop na #50755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jan 15, 2023
phofl
reviewed
Jan 15, 2023
mroeschke
reviewed
Jan 16, 2023
pandas/tests/groupby/test_groupby.py
Outdated
| df = DataFrame({"A": ["a", np.nan, "b", np.nan, "c"], "B": range(5)}) | ||
|
|
||
| if method == "nth": | ||
| result = df.groupby("A").agg(method, n=0) |
There was a problem hiding this comment.
Could you call the actual methods instead of using agg?
There was a problem hiding this comment.
Okay, how about this time?
mroeschke
added
Testing
mroeschke
approved these changes
Jan 17, 2023
|
Thanks @luke396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile when a bug was fixed or a new feature was added.referred to TST: Added test for groupby dropping NA when grouping by columns from pbhoopala