Update push activity and push details views to query _PushStatus #378

JeremyPlease · 2016-05-26T17:21:14Z

Originally Parse Dashboard used some custom endpoints to Parse for fetching push notifications and statuses. Now, the "_PushStatus" class in Parse Server can be queried directly when using the master key. From what I can tell, this has been available since Parse Server v2.2.8.

There's still a lot of stale/unused code regarding push notifications (experiments, audiences, push opens, scheduled pushes, etc.). I'm not sure what (if any) of those features will eventually be implemented, so I kept most of that code untouched.

This pull request gives the basic functionality of:

Viewing the list of all pushes with the "load more" button for loading more.
The detailed view of individual pushes to show pushes sent and targeting.

One thing to note is that Parse Server has a "source" of "rest" for all push notifications right now. So, all push notifications in the dashboard will have a "type" of "api" in the list view. Parse Server will need some updates to accept the "source" as part of Parse.Push.send(...).

Please try this out with your Parse Server apps and let me know if you have any problems, suggestions, comments, or feedback. Thanks!

_PushStatus class in Parse Server can be queried directly when using the master key. This allows us some basic functionality of viewing push history and statuses.

facebook-github-bot · 2016-05-26T17:21:50Z

By analyzing the blame information on this pull request, we identified @drew-gross, @gavrix and @durunvo to be potential reviewers.

drew-gross · 2016-05-26T19:03:08Z

src/dashboard/DashboardView.react.js


-    if (features.push && features.push.storedPushData) {
+    if (features.push && parseServerVersion >= '2.2.8') {


We are trying to avoid inspecting the server version directly, and instead adding info to the serverInfo endpoint in Parse Server to let the dashboard know that new features are available. Could you do that instead?

This particular check would also start to fail once we get to 2.10.0 or etc.

Got it. I'll change back to features.push.storedPushData and submit a PR to Parse Server to update that value.

And, yeah, version string comparison 😞

drew-gross · 2016-05-26T19:11:42Z

Wow this looks awesome! Just a few suggestions then we can merge this. We are going to do a new release of Parse Server soon so any changes that need to be made there will be able to go out quickly.

… enabling push activity

…eck if query is set

facebook-github-bot · 2016-05-26T19:25:49Z

@JeremyPlease updated the pull request.

It's assumed that when push is available, the pushHandler is used and data is saved in _PushStatus. This allows Parse Dashboard push history to be enabled: parse-community/parse-dashboard#378

JeremyPlease · 2016-05-26T19:48:11Z

Thanks, @drew-gross! Everything should be good to go with this PR and the referenced PR in Parse Server.

…1923) It's assumed that when push is available, the pushHandler is used and data is saved in _PushStatus. This allows Parse Dashboard push history to be enabled: parse-community/parse-dashboard#378

drew-gross · 2016-05-26T21:47:32Z

Great. We can get this into a release shortly after the next Parse Server version.

JeremyPlease · 2016-06-01T14:51:33Z

@drew-gross I saw the recent release of a new Parse Server version. Any schedule/plan for the next release of Parse Dashboard?

Thanks!

drew-gross · 2016-06-01T17:27:37Z

Want to review #390? Then I can do a release.

drew-gross · 2016-06-01T17:27:49Z

^ @JeremyPlease

MattiaConfalonieri · 2016-06-02T10:40:16Z

After update at last version (Parse dashboard and Parse server) Past Pushes in the dash infinite load and don't show nothing... have i to set something in the server?

JeremyPlease · 2016-06-02T14:42:49Z

@MattiaConfalonieri everything works as expected for me (screenshot).

Two questions for you:

What's in your browser's dev tool network log on that page? Are the pushes being fetched properly and are there any errors in the console.
Could you export the data in your _PushStatus collection in mongodb and attach it here? Perhaps there is something in your pushes that's not being handled correctly by dashboard.

MattiaConfalonieri · 2016-06-02T15:12:52Z

@JeremyPlease thanks for reply and sorry if i am so newbie
my push work properly without problem and u i can see push sent in parse.com dash with 0 sent. (but i have many recipient)

here log error on the dash page

[Error] TypeError: n.indexOf is not a function. (In 'n.indexOf("Z")', 'n.indexOf' is undefined)
    le (dashboard.bundle.js:38:2207)
    value (dashboard.bundle.js:38:5000)
    (funzione anonima) (dashboard.bundle.js:38:6913)
    map
    value (dashboard.bundle.js:38:6882)
    value (dashboard.bundle.js:1:15587)
    _renderValidatedComponentWithoutOwnerOrContext (dashboard.bundle.js:50:16768)
    _renderValidatedComponent (dashboard.bundle.js:50:16896)
    _updateRenderedComponent (dashboard.bundle.js:50:16229)
    _performComponentUpdate (dashboard.bundle.js:50:16029)
    updateComponent (dashboard.bundle.js:50:15306)
    performUpdateIfNecessary (dashboard.bundle.js:50:14738)
    performUpdateIfNecessary (dashboard.bundle.js:7:14677)
    s (dashboard.bundle.js:5:19711)
    perform (dashboard.bundle.js:9:17852)
    perform (dashboard.bundle.js:9:17852)
    perform (dashboard.bundle.js:5:20775)
    k (dashboard.bundle.js:5:20947)
    (funzione anonima)
    closeAll (dashboard.bundle.js:9:18489)
    perform (dashboard.bundle.js:9:17939)
    batchedUpdates (dashboard.bundle.js:51:8343)
    l (dashboard.bundle.js:5:19983)
    r (dashboard.bundle.js:29:23910)
    enqueueSetState (dashboard.bundle.js:29:24701)
    setState (dashboard.bundle.js:29:9522)
    (funzione anonima) (dashboard.bundle.js:38:2946)
    s (dashboard.bundle.js:4:24070)
    value (dashboard.bundle.js:4:23430)
    (funzione anonima) (dashboard.bundle.js:4:24141)
    s (dashboard.bundle.js:4:24070)
    (funzione anonima) (dashboard.bundle.js:4:24683)
    u (dashboard.bundle.js:4:24486)
    value (dashboard.bundle.js:4:24664)
    s (dashboard.bundle.js:4:24114)
    value (dashboard.bundle.js:4:23430)
    s (dashboard.bundle.js:4:24197)
    value (dashboard.bundle.js:4:23430)
    s (dashboard.bundle.js:4:24197)
    value (dashboard.bundle.js:4:23430)
    (funzione anonima) (dashboard.bundle.js:4:24141)
    s (dashboard.bundle.js:4:24070)
    value (dashboard.bundle.js:4:23430)
    onreadystatechange (dashboard.bundle.js:46:26776)

MattiaConfalonieri · 2016-06-04T09:31:24Z

Any idea? how i can solve the problem?

Update push activity and push details views to query _PushStatus

b167861

_PushStatus class in Parse Server can be queried directly when using the master key. This allows us some basic functionality of viewing push history and statuses.

facebook-github-bot added GH Review: review-needed labels May 26, 2016

drew-gross reviewed May 26, 2016
View reviewed changes

drew-gross added GH Review: needs-revision and removed GH Review: review-needed labels May 26, 2016

JeremyPlease added 3 commits May 26, 2016 15:14

Remove some rogue console.log's

ff26b7d

Rely on Parse Server setting features.push.storedPushData to true for…

6a911b0

… enabling push activity

In PushUtils tableInfoBuilder attempt to parse query json and then ch…

3bf0bb8

…eck if query is set

ghost added GH Review: review-needed and removed GH Review: needs-revision labels May 26, 2016

JeremyPlease mentioned this pull request May 26, 2016

Set push.storedPushData in serverInfo features if push is available parse-community/parse-server#1923

Merged

drew-gross added GH Review: accepted and removed GH Review: review-needed labels May 26, 2016

drew-gross merged commit 9b5dfb0 into parse-community:master May 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update push activity and push details views to query _PushStatus #378

Update push activity and push details views to query _PushStatus #378

Uh oh!

JeremyPlease commented May 26, 2016

Uh oh!

facebook-github-bot commented May 26, 2016

Uh oh!

drew-gross May 26, 2016

Uh oh!

JeremyPlease May 26, 2016

Uh oh!

drew-gross commented May 26, 2016

Uh oh!

facebook-github-bot commented May 26, 2016

Uh oh!

JeremyPlease commented May 26, 2016

Uh oh!

drew-gross commented May 26, 2016

Uh oh!

JeremyPlease commented Jun 1, 2016

Uh oh!

drew-gross commented Jun 1, 2016

Uh oh!

drew-gross commented Jun 1, 2016

Uh oh!

MattiaConfalonieri commented Jun 2, 2016

Uh oh!

JeremyPlease commented Jun 2, 2016

Uh oh!

MattiaConfalonieri commented Jun 2, 2016 •

edited

Loading

Uh oh!

MattiaConfalonieri commented Jun 4, 2016

Uh oh!

Uh oh!


		if (features.push && features.push.storedPushData) {
		if (features.push && parseServerVersion >= '2.2.8') {

Uh oh!

Update push activity and push details views to query _PushStatus #378

Update push activity and push details views to query _PushStatus #378

Uh oh!

Conversation

JeremyPlease commented May 26, 2016

Uh oh!

facebook-github-bot commented May 26, 2016

Uh oh!

drew-gross May 26, 2016

Choose a reason for hiding this comment

Uh oh!

JeremyPlease May 26, 2016

Choose a reason for hiding this comment

Uh oh!

drew-gross commented May 26, 2016

Uh oh!

facebook-github-bot commented May 26, 2016

Uh oh!

JeremyPlease commented May 26, 2016

Uh oh!

drew-gross commented May 26, 2016

Uh oh!

JeremyPlease commented Jun 1, 2016

Uh oh!

drew-gross commented Jun 1, 2016

Uh oh!

drew-gross commented Jun 1, 2016

Uh oh!

MattiaConfalonieri commented Jun 2, 2016

Uh oh!

JeremyPlease commented Jun 2, 2016

Uh oh!

MattiaConfalonieri commented Jun 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MattiaConfalonieri commented Jun 4, 2016

Uh oh!

Uh oh!

MattiaConfalonieri commented Jun 2, 2016 •

edited

Loading