Release 1.0.13 and fix bug when push alert is an object #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @JeremyPlease, @flovilmart and @durunvo to be potential reviewers. |
ghost
added
| @@ -145,7 +145,7 @@ let getPushName = (pushData) => { | |||
| payload = JSON.parse(payload); | |||
| } catch(e) { } | |||
| if(payload){ | |||
| return payload.alert ? payload.alert : payload; | |||
| return payload.alert ? payload.alert.toString() : payload; | |||
There was a problem hiding this comment.
@drew-gross If payload.alert is an object then the push name will be "[object Object]". Can we do the following instead to handle objects and strings:
return payload.alert ? JSON.stringify(payload.alert) : payload;
|
One comment/suggestion. Otherwise, looks good! |
|
Yeah thats definitely a better idea. Thanks! |
|
@drew-gross updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.