Remove Default API #332
Merged
Remove Default API #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 98.76% 98.77% +<.01%
==========================================
Files 34 34
Lines 2682 2696 +14
==========================================
+ Hits 2649 2663 +14
Misses 33 33
Continue to review full report at Codecov.
|
|
Cool 😎. I think I'll open up some PRs / issues on the other sdks as well. See if we can't get those old defaults scrubbed out. |
dplewis
pushed a commit
to dplewis/parse-php-sdk
that referenced
this pull request
Jul 12, 2017
* Removed default api and added appropriate checking * lint
montymxb
pushed a commit
that referenced
this pull request
Jul 12, 2017
* Add ParsePolygon Type and polygonContains query * test class fix * error handling for polygon * Update PHP_CodeSniffer (#328) * Add lint * update travis * coding style * add coverage to gitignore * removed ignore lines * nit * Updated parse-php-sdk to version 1.2.9 * Corrects and updates phpdoc references/errors (#329) * Corrects and updates phpdoc references/errors * Lint fixes * Added 'Getting Started' to README.md Adds a **Getting Started** section to README.md to direct newcomers to the [official guide](http://docs.parseplatform.org/php/guide/) and [API reference](http://parseplatform.org/parse-php-sdk/namespaces/Parse.html). * Remove Default API (#332) * Removed default api and added appropriate checking * lint * Pages autodeploy and phpdoc style enforcing (#335) * Added 'document-check' to add phpdoc checking during tests and added deploy for api ref on gh-pages * Wrapping filename in quotes * Moved bash out of package.json * Unescaping strings * Testing missing block comment * Fixing lint exception to expose phpdoc style issue * Restored class summary * removed comment * fix documentation * Pinned jms/serializer to 1.7.1 (#336) * Pinned jms/serializer to 1.7.1 * Checking to update jms/serializer to 1.8.0 ONLY on php 5.4 for travis-ci * Added comment, and added graphviz for class diagrams in generated api docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default url is
https://api.parse.com/and the default mount path if/1. Given that api.parse.com is no longer active and will only respond to requests with the messageParse.com has shutdown - https://parseplatform.github.io/it is probably time to clear these defaults.Additionally it would appear that there is no valid certificate for this api. Attempting to connect to the original service from this sdk will throw a
ParseExceptioncontaining the following message:This can be further verified through additional means (curl through the terminal, browser, etc).
This PR removes the default server url and mount path variables, and adds verification in
ParseClient::_requestthat both the server url and the mount path have been initialized before proceeding. Tests have been added to account for both cases as well.::EDIT::
This also contains a couple typo changes where
Parse::initializewas stated in an exception message where it should beParseClient::initialize. The relevant test cases were updated as well.