Skip to content

Pinned jms/serializer to 1.7.1 #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2017

Conversation

montymxb
Copy link
Contributor

Fixes an issue observed with jms/serializer being recently updated to 1.8.0, which causes phpdoc to fail outright with the following exception and trace:

Fatal error: Uncaught exception 'Doctrine\Common\Annotations\AnnotationException' with message '[Semantical Error] The annotation "@JMS\Serializer\Annotation\Type" in property phpDocumentor\Configuration::$title does not exist, or could not be auto-loaded.' in /Users/Bfriedman/Documents/parse-community/parse-php-sdk/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationException.php:54
Stack trace:
#0 /Users/Bfriedman/Documents/parse-community/parse-php-sdk/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/DocParser.php(734): Doctrine\Common\Annotations\AnnotationException::semanticalError('The annotation ...')
#1 /Users/Bfriedman/Documents/parse-community/parse-php-sdk/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/DocParser.php(663): Doctrine\Common\Annotations\DocParser->Annotation()
#2 /Users/Bfriedman/Documents/parse-community/parse-php-sdk/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/DocParser.php(354): Doctrine\Common\Annotations\DocParser->Annotations()
#3 /Use in /Users/Bfriedman/Documents/parse-community/parse-php-sdk/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationException.php on line 54

@codecov
Copy link

codecov bot commented Jul 12, 2017

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          34       34           
  Lines        2696     2696           
=======================================
  Hits         2663     2663           
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b148730...c7e0961. Read the comment docs.

@montymxb montymxb merged commit fb0b352 into parse-community:master Jul 12, 2017
dplewis pushed a commit to dplewis/parse-php-sdk that referenced this pull request Jul 12, 2017
* Pinned jms/serializer to 1.7.1

* Checking to update jms/serializer to 1.8.0 ONLY on php 5.4 for travis-ci

* Added comment, and added graphviz for class diagrams in generated api docs
@montymxb montymxb deleted the phpdoc-jms-fix branch July 12, 2017 18:51
montymxb pushed a commit that referenced this pull request Jul 12, 2017
* Add ParsePolygon Type and polygonContains query

* test class fix

* error handling for polygon

* Update PHP_CodeSniffer (#328)

* Add lint

* update travis

* coding style

* add coverage to gitignore

* removed ignore lines

* nit

* Updated parse-php-sdk to version 1.2.9

* Corrects and updates phpdoc references/errors (#329)

* Corrects and updates phpdoc references/errors

* Lint fixes

* Added 'Getting Started' to README.md

Adds a **Getting Started** section to README.md to direct newcomers to the [official guide](http://docs.parseplatform.org/php/guide/) and [API reference](http://parseplatform.org/parse-php-sdk/namespaces/Parse.html).

* Remove Default API (#332)

* Removed default api and added appropriate checking

* lint

* Pages autodeploy and phpdoc style enforcing (#335)

* Added 'document-check' to add phpdoc checking during tests and added deploy for api ref on gh-pages

* Wrapping filename in quotes

* Moved bash out of package.json

* Unescaping strings

* Testing missing block comment

* Fixing lint exception to expose phpdoc style issue

* Restored class summary

* removed comment

* fix documentation

* Pinned jms/serializer to 1.7.1 (#336)

* Pinned jms/serializer to 1.7.1

* Checking to update jms/serializer to 1.8.0 ONLY on php 5.4 for travis-ci

* Added comment, and added graphviz for class diagrams in generated api docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant