Skip to content

Allow to configure the QueryDefaultsPlugin #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 8, 2018

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets php-http/client-common#67
Documentation php-http/documentation#243
License MIT

What's in this PR?

Allow to configure the QueryDefaultsPlugin

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

@ruudk
Copy link
Contributor Author

ruudk commented Nov 13, 2018

Anything I need to change to get this merged? 😊

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with minor comments

@dbu dbu merged commit f093452 into php-http:master Nov 13, 2018
@dbu
Copy link
Collaborator

dbu commented Nov 13, 2018

thanks a lot!

@ruudk ruudk deleted the query_defaults branch November 13, 2018 09:35
@dbu
Copy link
Collaborator

dbu commented Nov 13, 2018

tagged 1.13.0 with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants