Skip to content

Allow to configure the QueryDefaultsPlugin #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

Allow to configure the QueryDefaultsPlugin #243

merged 1 commit into from
Nov 13, 2018

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 8, 2018

@ruudk ruudk mentioned this pull request Nov 8, 2018
Merged
2 tasks
@ruudk ruudk force-pushed the query-defaults branch 3 times, most recently from 69a7a39 to 0360e69 Compare November 13, 2018 09:32
dbu
dbu requested changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me apart from a sphinx nitpick and the defaultUserAgent copy-paste

dbu
dbu reviewed Nov 13, 2018
View reviewed changes
@ruudk
Copy link
Contributor Author

ruudk commented Nov 13, 2018

@dbu Updated PR

dbu
dbu approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@dbu dbu merged commit f37f0d7 into php-http:master Nov 13, 2018
@ruudk ruudk deleted the query-defaults branch November 13, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruudk @dbu