Final #19
Merged
Final #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function sendRequest(RequestInterface $request) | ||
| { | ||
| // TODO: Implement sendRequest() method. |
There was a problem hiding this comment.
? and why is this class embedded in the spec file?
There was a problem hiding this comment.
It's a stub. We need something which implements both interfaces, and it can't be final.
There was a problem hiding this comment.
then lets call it StubCombinedClient and not write TODO here but just have empty body. and a class phpdoc that says this is a stub for testing.
|
lets add an issue in the 2.0 milestone to remember to make them final and solve the TODO. |
sagikazarmark
force-pushed
the
final
branch
2 times, most recently
from
94537ea to
c8863d6
Compare
| @@ -11,7 +11,7 @@ | |||
| * | |||
| * @author Joel Wurtz <[email protected]> | |||
| */ | |||
| class FlexibleHttpClient implements HttpClient, HttpAsyncClient | |||
| final class FlexibleHttpClient implements HttpClient, HttpAsyncClient | |||
There was a problem hiding this comment.
did we want to rename this to CombinedHttpClient now?
There was a problem hiding this comment.
Don't know, rename is discussed in #16, although no better name came up yet IMO.
Make not-yet-released clients final Update changelog Remove TODOs in favor of #20
|
Didn't need the stub after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Makes some clients final, adds todos for clients becoming final in the next major version.
Why?
Cleans the confusion about clients being extended or not.
Checklist