Document Socket client

[ddeboer]

Ref php-http/socket-client#4

[dbu]

s/need/needs/

[dbu]

👍

i think we might want a partial to include on all client docs to mention the plugin system. with a minimal client like this one, its particularly important. the client does not follow redirects for example.

[dbu]

we could add the note on plugins in the footer that talks about async and message factory (the one we said in #67 that we will separate it out later). does this client support async at all? if not, we maybe want a little table with the feature overview for each client...

[sagikazarmark]

IMO all clients which support async should be implemented as async in the adapter as well, but async emulation should not be done by default.

[ddeboer]

Updated according to feedback.

does this client support async at all?

No.

i think we might want a partial to include on all client docs to mention the plugin system.

Done.

[dbu]

we could mention that the plain client is configured to not follow redirects for example.

[ddeboer]

Is that the same for all our clients or does it differ between them?

[dbu]

it should be. if a client follows redirects, we end up with inconsistency and unexpected behaviour. we try to set the adapter clients minimal, see php-http/guzzle6-adapter#19 for example. ensuring this would be part of the job of the functional test suite we talked about recently...

[dbu]

looks good. we could tweak the further reading, if you want. and it would be good to have input from joel on the remote_socket option. but both are imho not blockers for merging.

[sagikazarmark]

👍

[joelwurtz]

👍 except for the example :), huge thanks for taking time to do the documentation @ddeboer !

[ddeboer]

Tweaked further reading by giving some plugin examples.

[dbu]

👍