This repository was archived by the owner on Jan 6, 2024. It is now read-only.
reduced default guzzle set up #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P status codes, not following redirects, not handling cookies
| $this->client = $client ?: new Client(); | ||
| if (!$client) { | ||
| $handlerStack = new HandlerStack(); | ||
| $handlerStack->push(Middleware::prepareBody(), 'prepare_body'); |
There was a problem hiding this comment.
as per #13, we keep the prepareBody functionality. contrary to redirect, exception and cookie, it does not change behaviour and there is no reason to not want this. also, if we add php-http plugins that handle content-length, this middleware realizes the value is already set and leaves things alone.
|
👍 |
1 similar comment
|
👍 |
joelwurtz
added a commit
that referenced
this pull request
Dec 17, 2015
reduced default guzzle set up
2 tasks
|
This is actually causing me a problem. When I revert this change, it works as expected. |
|
Fix is on it's way |
sagikazarmark
added a commit
that referenced
this pull request
Dec 22, 2015
sagikazarmark
added a commit
that referenced
this pull request
Dec 22, 2015
Fix No handler specified issue introduced in #19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set up guzzle client as very minimal, not throwing exceptions for HTTP status codes, not following redirects, not handling cookies
fix #13