Skip to content

Support for symfony 6 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support for symfony 6 #17

wants to merge 1 commit into from

Conversation

GeoDpto
Copy link
Contributor

@GeoDpto GeoDpto commented Dec 5, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

Support for symfony 6.

@dbu
Copy link
Contributor

dbu commented Dec 6, 2021

thanks!

i realized that the CI no longer worked. i fixed it in the master branch - can you please rebase and add an entry in the .github/workflow/tests.yml for the new symfony version?

@dbu
Copy link
Contributor

dbu commented Dec 6, 2021

weird, the build succeeded with the old symfony constraint: https://github.com/php-http/stopwatch-plugin/actions/runs/1543787287

oh wait, i missed to actually apply the constraint 🙈 - can you rebase on master again please? after that, the symfony 5 build should no longer fail, i think.

@GeoDpto
Copy link
Contributor Author

GeoDpto commented Dec 6, 2021

phpspec/phpspec package is not compatible with SF 6 :(

We need to wait while the package will update to the new version.
phpspec/phpspec#1402

@dbu
Copy link
Contributor

dbu commented Dec 6, 2021

i fear you are right. lets hope they can release an updated version soon. my guess is that we would not have any issues in this plugin, but i'd rather not merge without knowing.

@ruudk
Copy link
Contributor

ruudk commented Jan 11, 2022

What about removing PHPSpec and just use a good old PHPUnit test?

I mean, look at this small spec test: https://github.com/php-http/stopwatch-plugin/blob/master/spec/StopwatchPluginSpec.php
No need to keep this blocked if you ask me.

@ruudk
Copy link
Contributor

ruudk commented Jan 14, 2022

Discussed with @Nyholm and decided to drop PHPSpec. Did that in #21. When that is merged you can rebase.

@ruudk ruudk mentioned this pull request Jan 14, 2022
@ruudk
Copy link
Contributor

ruudk commented Jan 14, 2022

Rebased this PR in #22 , so that we can merge and tag it!

@dbu
Copy link
Contributor

dbu commented Jan 14, 2022

merged in #22. thanks a lot @GeoDpto and @ruudk

@dbu dbu closed this Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants