Replace PHPSpec with PHPUnit #21
Conversation
ruudk
force-pushed
the
replace-phpspec
branch
2 times, most recently
from
c703d19 to
850833a
Compare
PHPSpec blocks the upgrade to Symfony 6. Replacing it with the industry standard PHPUnit. This makes it way easier for contributors to work on the code.
ruudk
force-pushed
the
replace-phpspec
branch
from
850833a to
b9f7067
Compare
| /** | ||
| * @test | ||
| */ | ||
| public function it_records_event(): void |
There was a problem hiding this comment.
the phpunit convention is to have methods start with test and then we would not need the annotation.
i don't know how much people use this form or the other form (but all things i work on have the testXY form). wdyt of renaming this to testRecordEvent, and the other testRecordError ?
There was a problem hiding this comment.
both are fine.. in our code base we only use it_should_be.... together with @test
I decided to keep the original names from phpspec... given there are just 2, does it really matter? :)
There was a problem hiding this comment.
no, does not really matter. just noticed and wanted to discuss it. fine for me.
|
the scrutinizer build failure is because of required branch checks. Can be removed after merging the pr. edit: seems like it's not required... would be nice to setup requirements btw. |
|
thanks @ruudk ! |
|
Thank you both! |
PHPSpec blocks the upgrade to Symfony 6. Replacing it with the industry standard PHPUnit.
This makes it way easier for contributors to work on the code.
Also dropped Scrutinizer.
See #17