refactor: switch from JsonSerializable to normalizer
#301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
commented
May 4, 2025
chr-hertel
commented
May 4, 2025
chr-hertel
commented
May 4, 2025
chr-hertel
force-pushed
the
refactor-contract-handling
branch
from
591474f to
c6ba1ce
Compare
OskarStark
reviewed
May 5, 2025
OskarStark
reviewed
May 5, 2025
chr-hertel
force-pushed
the
refactor-contract-handling
branch
from
c6ba1ce to
4406c4f
Compare
chr-hertel
force-pushed
the
refactor-contract-handling
branch
from
4406c4f to
d090593
Compare
chr-hertel
force-pushed
the
refactor-contract-handling
branch
from
d090593 to
2b5477b
Compare
chr-hertel
changed the title
OskarStark
changed the title
JsonSerializable to normalizer
This was referenced May 19, 2025
chr-hertel
force-pushed
the
refactor-capabilities
branch
4 times, most recently
from
4c2fa37 to
964e4a8
Compare
chr-hertel
force-pushed
the
refactor-contract-handling
branch
from
2b5477b to
10ec3ff
Compare
chr-hertel
commented
May 26, 2025
There was a problem hiding this comment.
could be ToolCallNormalizer?
chr-hertel
force-pushed
the
refactor-contract-handling
branch
from
10ec3ff to
1541b6b
Compare
chr-hertel
force-pushed
the
refactor-capabilities
branch
from
964e4a8 to
e7a5702
Compare
chr-hertel
force-pushed
the
refactor-contract-handling
branch
from
1541b6b to
2b557f8
Compare
4 tasks
|
closed in favor of #326 |
chr-hertel
added a commit
that referenced
this pull request
Jun 1, 2025
- [x] Introducing global model class to be more agnostic with explicit `Capability` class - [x] Introducing Contract with Normalizers to solve Base Contract (OpenAI) vs. Model/Platform specific differences - [x] Reshape into three major components `Chain`, `Platform` and `Store` - [x] Adoption of Symfony-style for CS Fixer and `Interface` & `Exception` suffix Replaces #301 and #305 # Breaking Changes * Sorting into three main sub compontents `Platform`, `Chain` and `Store` * High level implementation also went into those components, see `ChainInterface` as example * `Model` namespace went into `Platform` * Bridges got sorted into `Platform` or `Store` * Tool metadata moved from `Chain` to `Platform\Contract` * Implementation of `JsonSerializable` was dropped in favor of Symfony's serializer/normalizer * Removal of `LanguageModel` and `EmbeddingsModel` interface in favor of base `Model` and `Capabilities` * Renaming of `StructuredResponse` to `ObjectResponse` * Slimming down the `supports()` method of `ModelClient` and `ResponseConverter` * Changing signature of `ModelClient` to already accepting the normalized request payload * Renaming interfaces to always contain the `Interface` suffix * Renaming exceptions to always contain the `Exception` suffix
chr-hertel
added a commit
that referenced
this pull request
Jun 1, 2025
- [x] Introducing global model class to be more agnostic with explicit `Capability` class - [x] Introducing Contract with Normalizers to solve Base Contract (OpenAI) vs. Model/Platform specific differences - [x] Reshape into three major components `Chain`, `Platform` and `Store` - [x] Adoption of Symfony-style for CS Fixer and `Interface` & `Exception` suffix Replaces #301 and #305 * Sorting into three main sub compontents `Platform`, `Chain` and `Store` * High level implementation also went into those components, see `ChainInterface` as example * `Model` namespace went into `Platform` * Bridges got sorted into `Platform` or `Store` * Tool metadata moved from `Chain` to `Platform\Contract` * Implementation of `JsonSerializable` was dropped in favor of Symfony's serializer/normalizer * Removal of `LanguageModel` and `EmbeddingsModel` interface in favor of base `Model` and `Capabilities` * Renaming of `StructuredResponse` to `ObjectResponse` * Slimming down the `supports()` method of `ModelClient` and `ResponseConverter` * Changing signature of `ModelClient` to already accepting the normalized request payload * Renaming interfaces to always contain the `Interface` suffix * Renaming exceptions to always contain the `Exception` suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address pain of #291 and #297