refactor: Major Library Refactoring #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2025
chr-hertel
force-pushed
the
refactoring-restructure
branch
from
2b74225 to
93e20de
Compare
chr-hertel
force-pushed
the
refactoring-restructure
branch
9 times, most recently
from
0b350b4 to
df8fa7e
Compare
chr-hertel
commented
May 30, 2025
chr-hertel
force-pushed
the
refactoring-restructure
branch
8 times, most recently
from
07f90c6 to
aeaf22b
Compare
chr-hertel
force-pushed
the
refactoring-restructure
branch
from
aeaf22b to
78f5894
Compare
chr-hertel
added a commit
that referenced
this pull request
Jun 1, 2025
- [x] Introducing global model class to be more agnostic with explicit `Capability` class - [x] Introducing Contract with Normalizers to solve Base Contract (OpenAI) vs. Model/Platform specific differences - [x] Reshape into three major components `Chain`, `Platform` and `Store` - [x] Adoption of Symfony-style for CS Fixer and `Interface` & `Exception` suffix Replaces #301 and #305 * Sorting into three main sub compontents `Platform`, `Chain` and `Store` * High level implementation also went into those components, see `ChainInterface` as example * `Model` namespace went into `Platform` * Bridges got sorted into `Platform` or `Store` * Tool metadata moved from `Chain` to `Platform\Contract` * Implementation of `JsonSerializable` was dropped in favor of Symfony's serializer/normalizer * Removal of `LanguageModel` and `EmbeddingsModel` interface in favor of base `Model` and `Capabilities` * Renaming of `StructuredResponse` to `ObjectResponse` * Slimming down the `supports()` method of `ModelClient` and `ResponseConverter` * Changing signature of `ModelClient` to already accepting the normalized request payload * Renaming interfaces to always contain the `Interface` suffix * Renaming exceptions to always contain the `Exception` suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CapabilityclassChain,PlatformandStoreInterface&ExceptionsuffixReplaces #301 and #305
Breaking Changes
Platform,ChainandStoreChainInterfaceas exampleModelnamespace went intoPlatformPlatformorStoreChaintoPlatform\ContractJsonSerializablewas dropped in favor of Symfony's serializer/normalizerLanguageModelandEmbeddingsModelinterface in favor of baseModelandCapabilitiesStructuredResponsetoObjectResponsesupports()method ofModelClientandResponseConverterModelClientto already accepting the normalized request payloadInterfacesuffixExceptionsuffix