Saner array_(sum|product)() #10161
Merged
Saner array_(sum|product)() #10161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
reviewed
Dec 26, 2022
kocsismate
reviewed
Dec 26, 2022
Girgias
force-pushed
the
sane-array-ops
branch
from
40b35a8 to
1aa7547
Compare
kocsismate
reviewed
Dec 30, 2022
Girgias
force-pushed
the
sane-array-ops
branch
from
1aa7547 to
c6b0666
Compare
Girgias
force-pushed
the
sane-array-ops
branch
from
c6b0666 to
b2cf406
Compare
kocsismate
reviewed
Jan 27, 2023
Introduce such a dummy class in the zend_test extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/saner-array-sum-product
The current behaviour of
array_sum()andarray_product()is outright insane.int|floatto perform the operation, this includes resources and non-numeric strings which as of PHP 8.0 throwTypeErrors when used with arithmetic operations.The objective of this PR, and yet to be written RFC, is to align the behaviour of these two functions as close as possible to doing:
array_reduce($input, fn($carry, $value) => $carry + $value, 0)forarray_sum($input)andarray_reduce($input, fn($carry, $value) => $carry * $value, 1)forarray_product($input).To achieve this in a backwards compatible manner, we emit warnings for types which should throw type errors while still applying the current behaviour. Moreover, we now support performing the binary operation on objects that support it instead of ignoring them.
The one difference with the
array_reduce()implementation is that if the traversal of the array encountered objects that supported the relevant binary operation, it also needs to be castable toint|floatto preserve the return type of these functions.