ext/sockets update the sock_filter usage for the CPBF filter. #10931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to add some comments so it is clear what it is doing without further digging. |
devnexen
force-pushed
the
socket_cbpf_update
branch
from
a2f3554 to
427d676
Compare
iluuu1994
reviewed
Apr 20, 2023
ext/sockets/sockets.c
Outdated
| @@ -1969,17 +1969,39 @@ PHP_FUNCTION(socket_set_option) | |||
| opt_ptr = &ov; | |||
| optname = SO_DETACH_BPF; | |||
| } else { | |||
| /** | |||
| * this socket flag offers a tigher control over the SO_REUSEPORT's algorithm | |||
There was a problem hiding this comment.
Nit: Use punctuation and upper-case letters in comments with multiple sentences. Makes it easier to read 🙂
disapatching now (modulo) number of available cores.
devnexen
force-pushed
the
socket_cbpf_update
branch
from
427d676 to
860d79d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disapatching now (modulo) number of available cores.