Skip to content

ext/sockets update the sock_filter usage for the CPBF filter. #10931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/sockets update the sock_filter usage for the CPBF filter. #10931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions ext/sockets/sockets.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1969,17 +1969,39 @@ PHP_FUNCTION(socket_set_option)
opt_ptr = &ov;
optname = SO_DETACH_BPF;
} else {
/**
* This socket flag offers a tigher control over the SO_REUSEPORT's algorithm,
* here binding a socket to a particular cpu set as opposed to the Round-Robin
* default one.
*/
uint32_t k = (uint32_t)Z_LVAL_P(arg4);
static struct sock_filter cbpf[8] = {0};
static struct sock_fprog bpfprog;

// TODO: Might be a good enough approximation, more native api could be used potentially tough.
long onln = sysconf(_SC_NPROCESSORS_ONLN);

if (onln == -1) {
php_error_docref(NULL, E_WARNING, "Online cores fetching failed");
RETURN_FALSE;
}

switch (k) {
case SKF_AD_CPU:
case SKF_AD_QUEUE:
/**
* We are putting the current socket's filter operation into `A`
* instead of the current core, we are dispatching (modulo)
* among `onln` cores as opposed to bind it via the raw_smp_processor_id()
* kernel call.
* Then the sock's filter returns `A`
*/
cbpf[0].code = (BPF_LD|BPF_W|BPF_ABS);
cbpf[0].k = (uint32_t)(SKF_AD_OFF + k);
cbpf[1].code = (BPF_RET|BPF_A);
bpfprog.len = 2;
cbpf[1].code = (BPF_ALU | BPF_MOD);
cbpf[1].k = (uint32_t)(onln);
cbpf[2].code = (BPF_RET|BPF_A);
bpfprog.len = 3;
break;
default:
php_error_docref(NULL, E_WARNING, "Unsupported CBPF filter");
Expand Down