[Test] Optimized pdo_mysql tests #12555
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
tests/optimize-pdo-mysql-tests
branch
from
77ca72d to
fedccd1
Compare
SakiTakamachi
force-pushed
the
tests/optimize-pdo-mysql-tests
branch
from
fedccd1 to
4b16c62
Compare
Girgias
reviewed
Oct 29, 2023
ext/pdo_mysql/tests/bug53551.phpt
Outdated
Comment on lines
17
to
26
| $createSql = "CREATE TABLE `test` ( | ||
| `count` bigint(20) unsigned NOT NULL DEFAULT '0' | ||
| )"; | ||
|
|
||
| $db->exec('drop table if exists bug53551'); | ||
| $db->exec('drop table if exists test'); | ||
| $db->exec($createSql); | ||
| $db->exec("insert into bug53551 set `count` = 1 "); | ||
| $db->exec("insert into test set `count` = 1 "); | ||
| $db->exec("SET sql_mode = 'Traditional'"); | ||
| $sql = 'UPDATE bug53551 SET `count` = :count'; | ||
| $sql = 'UPDATE test SET `count` = :count'; | ||
| $stmt = $db->prepare($sql); |
There was a problem hiding this comment.
Please do not do this, each test should use it's own table so we can run them in parallel, and this also goes against #11879
SakiTakamachi
force-pushed
the
tests/optimize-pdo-mysql-tests
branch
from
4b16c62 to
a6e29ab
Compare
|
@Girgias |
SakiTakamachi
force-pushed
the
tests/optimize-pdo-mysql-tests
branch
from
a6e29ab to
b2df20d
Compare
SakiTakamachi
force-pushed
the
tests/optimize-pdo-mysql-tests
branch
2 times, most recently
from
4c86a38 to
64ba080
Compare
SakiTakamachi
force-pushed
the
tests/optimize-pdo-mysql-tests
branch
from
64ba080 to
f3280f7
Compare
Girgias
reviewed
Nov 2, 2023
Comment on lines
+2
to
4
| require_once(dirname(__FILE__) . DIRECTORY_SEPARATOR . 'init.inc'); | ||
| require_once(dirname(__FILE__) . str_replace('/', DIRECTORY_SEPARATOR, '/../../../../ext/pdo/tests/pdo_test.inc')); | ||
|
|
There was a problem hiding this comment.
Suggested change
| require_once(dirname(__FILE__) . DIRECTORY_SEPARATOR . 'init.inc'); | |
| require_once(dirname(__FILE__) . str_replace('/', DIRECTORY_SEPARATOR, '/../../../../ext/pdo/tests/pdo_test.inc')); | |
| require_once __DIR__ . DIRECTORY_SEPARATOR . 'init.inc'; | |
| require_once dirname(__DIR__, 4) . '/ext/pdo/tests/pdo_test.inc'; |
No need to convert paths for Windows, also do not use parenthesis around require as it is not a function but a language construct and the semantics are slightly different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[wip]
PDO's test specifications, especially the config, are too different, so I'm trying to unify them to some extent and make the tests easier to understand. However, changing everything at once would result in too many diffs, so I started with pdo_mysql first.
MySQLPDOTestmethods so that they can be reused.Other fixes
PDOTestand others usedMySQLPDOTest, we unified them intoMySQLPDOTest.common.phptis no longer needed, so I removed it. (I'm thinking of deletingcommon.phptfor other PDO drivers as well.)For some tests that only use one table, the table name has been unified to "test".--CLEAN--to tests that need to be cleaned up but have not been cleaned up.table.incis not used so I deleted it.The number of files is still quite large, so if you would like to split it up further, please let me know.