-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Refactor ext/pgsql
test
#12608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ext/pgsql
test
#12608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
It has been very annoying to need to run these tests sequentially.
Could you always use uppercase letters for SQL keywords, and CLEAN sections should use an IF EXISTS clause as the table may not be created in the test.
Fixed in 21e61ad All existing code unrelated to this pull request was also fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good now! Only a couple of nits and questions. :)
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
@Girgias |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final remark and good to merge :)
Thank you! |
I refactored the
ext/pgsql
tests based on some recent pull requests.The content and results remain unchanged. This is just an internal improvement.
With this refactoring, we can expect the following benefits:
Some tests were dependent on the execution order of previous and subsequent tests.
All tests can now be executed independently.
One test no longer interferes with another. All tests can be run in parallel.
Specifically, i made the following modifications: For readability, each modification is fixed in a separate commit.
--CLEAN--
to delete objects at the end of the test.faabc3f
*.inc
to another folder to make filenames easier to read.7b507cd
config.inc
002fe32 293b0b0
002fe32 5ab45c7
Ref:
ext/pdo_pgsql
tests cleanup #11855ext/pdo_mysql
tests cleanup #11879