Make the return type of some stream context related functions true #12720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the slight refactoring, it wasn't obvious that the related functions could only return true.
nielsdos
reviewed
Nov 18, 2023
Co-authored-by: Niels Dossche <[email protected]>
nielsdos
reviewed
Nov 18, 2023
|
|
||
| try { | ||
| stream_context_create(['ssl' => ['verify_peer'=> false]], ["options" => false]); | ||
| } catch (ValueError $exception) { |
Girgias
approved these changes
Nov 19, 2023
kocsismate
force-pushed
the
stream-context-return
branch
from
2fef794 to
9762421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the slight refactoring, it wasn't obvious that the related functions could only return true.