ext/curl: Fix failing tests due to string changes in libcurl 8.6.0 #13293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream libcurl 8.6.0 contains a change[^1] that caused a test failure. This fixes it by updating the test's `EXPECTF` to use a regex to account for both string patterns. [^1]: curl/curl@45cf4755e71f#diff-a8a54563608f8155973318f4ddb61d7328dab512b8ff2b5cc48cc76979d4204cL1683
nielsdos
approved these changes
Jan 31, 2024
iluuu1994
pushed a commit
to cmb69/php-src
that referenced
this pull request
Oct 23, 2024
Upstream libcurl 8.6.0 contains a change[^1] that caused a test failure. This fixes it by updating the test's `EXPECTF` to use a regex to account for both string patterns. [^1]: curl/curl@45cf4755e71f#diff-a8a54563608f8155973318f4ddb61d7328dab512b8ff2b5cc48cc76979d4204cL1683 Closes phpGH-13293.
iluuu1994
added a commit
that referenced
this pull request
Oct 28, 2024
Closes GH-16469 Working towards GH-16286 commit e0db221143b808d97bc3a44e9f0968c6308794b4 Author: Ilija Tovilo <[email protected]> Date: Fri Oct 25 22:48:20 2024 +0200 Move CFLAGS into ./configure command for consistency commit 8ad67768250d181cd7fef30e0c866625bbd8ac94 Author: Ilija Tovilo <[email protected]> Date: Fri Oct 25 22:47:03 2024 +0200 Also upgrade nightly to macOS 13 commit 58a88cc Author: Ilija Tovilo <[email protected]> Date: Wed Oct 23 19:07:59 2024 +0200 Fix call to dc[n]gettext in tests with 0 $category This causes a segfault on PHP-8.1 commit 611af05 Author: Ilija Tovilo <[email protected]> Date: Fri Dec 8 13:36:52 2023 +0100 [skip ci] Skip intermittently failing curl test on macOS The test fails with "CURL ERROR: 56". I will create an issue for it shortly. commit ec74517 Author: Ilija Tovilo <[email protected]> Date: Wed Oct 23 19:05:32 2024 +0200 Backport parts of 9999a0c for gettext See 9999a0c commit 5ce7034 Author: Niels Dossche <[email protected]> Date: Sun Jul 28 14:34:26 2024 +0200 Fix CI failure on macOS after Curl update commit 714a3e7 Author: Niels Dossche <[email protected]> Date: Sat Jul 27 16:09:50 2024 +0200 Fix CI failure after Curl update (#15124) commit 4f2eb92 Author: Niels Dossche <[email protected]> Date: Thu May 23 22:20:37 2024 +0200 Fix GH-14307: Test curl_basic_024 fails with curl 8.8.0 Curl changed the behaviour, from the changelog: - lib: make protocol handlers store scheme name lowercase curl/curl@c294f9c From the docs: "The returned scheme might be upper or lowercase. Do comparisons case insensitively." Closes GH-14312. commit 251195b Author: Ayesh Karunaratne <[email protected]> Date: Thu Feb 1 02:03:55 2024 +0700 ext/curl: Fix failing tests due to string changes in libcurl 8.6.0 Upstream libcurl 8.6.0 contains a change[^1] that caused a test failure. This fixes it by updating the test's `EXPECTF` to use a regex to account for both string patterns. [^1]: curl/curl@45cf4755e71f#diff-a8a54563608f8155973318f4ddb61d7328dab512b8ff2b5cc48cc76979d4204cL1683 Closes GH-13293. commit fc5d83f Author: Christoph M. Becker <[email protected]> Date: Wed Oct 16 22:46:20 2024 +0200 Prepare for necessary move to macOS 13 GH will remove macOS 12 runner images as of December 3rd, so we prepare for that. Besides the obvious need to change the runner, we also suppress a couple of warnings, because otherwise the build would fail due to `-Werror`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream libcurl 8.6.0 contains a change1 that caused a test failure. This fixes it by updating the test's
EXPECTFto use a regex to account for both string patterns.Replaces #13292.
Footnotes
https://github.com/curl/curl/commit/45cf4755e71f#diff-a8a54563608f8155973318f4ddb61d7328dab512b8ff2b5cc48cc76979d4204cL1683 ↩