Prepare for necessary move to macOS 13 #16469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That doesn't look bad (cf. https://github.com/php/php-src/actions/runs/11305938333/job/31445981077#step:8:2747). |
GH will remove macOS 12 runner images as of December 3rd, so we prepare for that. Besides the obvious need to change the runner, we also suppress a couple of warnings, because otherwise the build would fail due to `-Werror`.
|
By the way, why are we running debug builds on macOS (and one for Linux)? Wouldn't |
|
Some benefits of |
Upstream libcurl 8.6.0 contains a change[^1] that caused a test failure. This fixes it by updating the test's `EXPECTF` to use a regex to account for both string patterns. [^1]: curl/curl@45cf4755e71f#diff-a8a54563608f8155973318f4ddb61d7328dab512b8ff2b5cc48cc76979d4204cL1683 Closes phpGH-13293.
Curl changed the behaviour, from the changelog: - lib: make protocol handlers store scheme name lowercase curl/curl@c294f9c From the docs: "The returned scheme might be upper or lowercase. Do comparisons case insensitively." Closes phpGH-14312.
The test fails with "CURL ERROR: 56". I will create an issue for it shortly.
This causes a segfault on PHP-8.1
iluuu1994
force-pushed
the
cmb/macos-13
branch
from
5867367 to
58a88cc
Compare
|
@cmb69 I pushed the remaining necessary changes. Does this look good to you now? |
|
Yeah, sure. Thank you very much @iluuu1994! |
|
Any objections to merge this? Maybe @ramsey has something to say about this, since it targets PHP-8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH will remove macOS 12 runner images as of December 3rd, so we prepare for that.
https://app.github.media/e/es?s=88570519&e=3837111&elqTrackId=78D8A052C380BCBFF284D754BEBE9730&elq=f4dd0fae19804631a9520380d9a17f1f&elqaid=4233&elqat=1
Note that nightlies will affected by this, too, but maybe focus on the push workflows for now.