Skip to content

Update .gitignore #14158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2024
Merged

Update .gitignore #14158

merged 1 commit into from
May 8, 2024

Conversation

petk
Copy link
Member

@petk petk commented May 6, 2024

  • The headers mentioned in the comment are not "generated" anymore as done via eb76a83
  • zend_jit_.c files are now generated as part of the ext/opcache/jit/ir
  • generated minilua is ignored in ext/opcache/jit/ir/.gitignore

@petk
Update .gitignore
af25c08 
- The headers mentioned in the comment are not "generated" anymore as
  done via eb76a83
- zend_jit_<arch>.c files are now generated as part of the
  ext/opcache/jit/ir
- generated minilua is ignored in ext/opcache/jit/ir/.gitignore
@petk
Copy link
Member Author

petk commented May 6, 2024

Or perhaps these ext/opcache/* files should be left for a branch or two to make switching branches easier... Then I'll update only the comment here.

@iluuu1994
Copy link
Member

Or perhaps these ext/opcache/* files should be left for a branch or two to make switching branches easier... Then I'll update only the comment here.

Maybe, although we already have the same issue for the new JIT files. I usually just git clean -df. But yeah, it's slightly annoying.

@petk petk merged commit 0642855 into php:master May 8, 2024
10 checks passed
@petk petk deleted the patch-gitignore branch May 8, 2024 05:20
@petk petk mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @iluuu1994