Remove unused PHP-8.3 generated JIT files #14622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, looks like it. Ok. |
|
@petk So, maybe this shouldn't have been removed from the .gitignore yet ^^ |
To have smoother workflow when switching PHP branches this can be ignored for a branch or two.
devnexen
approved these changes
Jun 21, 2024
devnexen
pushed a commit
to devnexen/php-src
that referenced
this pull request
Jun 21, 2024
This remove unused PHP-8.3 generated JIT files and adds PHP-8.3 generated JIT files back to .gitignore to have smoother workflow when switching PHP branches this can be ignored for a branch or two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment looks scary (
DO NOT EDIT! The original file is in ...) so I wasn't sure if this is intentional or not but I think this was only "mis-commited". :D