run-tests: Fix getting stuck when the test process dies uncleanly #16456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a test process spawns a subprocess that keeps STDOUT open and then dies uncleanly, while writing something to STDERR `run-tests.php` would erroneously attempt to read from `STDOUT` and then get blocked until the subprocess dies (which might never happen).
TimWolla
force-pushed
the
run-tests_stuck_when_subprocess_exists
branch
from
5e23c92 to
f5973c8
Compare
|
@devnexen Do you happen to have an idea why this completely breaks on FreeBSD? And perhaps also for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test process spawns a subprocess that keeps STDOUT open and then dies uncleanly, while writing something to STDERR
run-tests.phpwould erroneously attempt to read fromSTDOUTand then get blocked until the subprocess dies (which might never happen).