run-tests: Fix getting stuck when the test process dies uncleanly

.github/actions/apt-x32/action.yml

@@ -45,6 +45,7 @@ runs:
           libxslt1-dev:i386 \
           libzip-dev:i386 \
           locales \
+          lsof \
           make \
           pkg-config:i386 \
           re2c \

.github/actions/apt-x64/action.yml

@@ -13,6 +13,7 @@ runs:
           locales \
           ldap-utils \
           openssl \
+          lsof \
           slapd \
           language-pack-de \
           libgmp-dev \

ext/openssl/tests/stream_server_reneg_limit.phpt

@@ -5,7 +5,7 @@ openssl
 --SKIPIF--
 <?php
 if (!function_exists("proc_open")) die("skip no proc_open");
-exec('openssl help', $out, $code);
+exec('openssl help 2> /dev/null', $out, $code);
 if ($code > 0) die("skip couldn't locate openssl binary");
 if(substr(PHP_OS, 0, 3) == 'WIN') {
     die('skip not suitable for Windows');

ext/phar/tests/tar/bug70417.phpt

@@ -6,7 +6,7 @@ zlib
 --SKIPIF--
 <?php
 
-exec('lsof -p ' . getmypid(), $out, $status);
+exec('lsof -p ' . getmypid() . ' 2> /dev/null', $out, $status);
 if ($status !== 0) {
     die("skip lsof(8) not available");
 }

ext/snmp/snmp.c

@@ -1997,6 +1997,13 @@ PHP_MINIT_FUNCTION(snmp)
 {
 	netsnmp_log_handler *logh;
 
+	/* Disable logging, use exit status'es and related variabled to detect errors */
+	shutdown_snmp_logging();
+	logh = netsnmp_register_loghandler(NETSNMP_LOGHANDLER_NONE, LOG_ERR);
+	if (logh) {
+		logh->pri_max = LOG_ERR;
+	}
+
 	init_snmp("snmpapp");
 	/* net-snmp corrupts the CTYPE locale during initialization. */
 	zend_reset_lc_ctype_locale();
@@ -2006,13 +2013,6 @@ PHP_MINIT_FUNCTION(snmp)
 	netsnmp_ds_set_boolean(NETSNMP_DS_LIBRARY_ID, NETSNMP_DS_LIB_DONT_PERSIST_STATE, 1);
 #endif
 
-	/* Disable logging, use exit status'es and related variabled to detect errors */
-	shutdown_snmp_logging();
-	logh = netsnmp_register_loghandler(NETSNMP_LOGHANDLER_NONE, LOG_ERR);
-	if (logh) {
-		logh->pri_max = LOG_ERR;
-	}
-
 	memcpy(&php_snmp_object_handlers, &std_object_handlers, sizeof(zend_object_handlers));
 	php_snmp_object_handlers.read_property = php_snmp_read_property;
 	php_snmp_object_handlers.write_property = php_snmp_write_property;

ext/snmp/tests/bug64159.phpt

@@ -22,6 +22,4 @@ var_dump(("ab8283f948419b2d24d22f44a80b17d3" === md5(snmpget($hostname, $communi
 
 ?>
 --EXPECTF--
-MIB search path: %s
-Cannot find module (noneXistent): At line %d in (%s)
 bool(true)

ext/standard/tests/file/bug81145.phpt

@@ -8,7 +8,7 @@ if (disk_free_space(__DIR__) < 0x220000000) die("skip insuffient disk space");
 if (PHP_OS_FAMILY !== "Windows") {
     $src = __DIR__ . "/bug81145_src.bin";
     define('SIZE_4G', 0x100000000);
-    exec("fallocate -l " . (SIZE_4G-0x100) . " " . escapeshellarg($src), $output, $status);
+    exec("fallocate -l " . (SIZE_4G-0x100) . " " . escapeshellarg($src) . " 2> /dev/null", $output, $status);
     if ($status !== 0) die("skip fallocate() not supported");
     @unlink(__DIR__ . "/bug81145_src.bin");
 }

ext/zend_test/tests/run-tests_stuck_when_subprocess_exists.phpt

@@ -0,0 +1,16 @@
+--TEST--
+run-tests: Does not get stuck when a test spawns a subprocess and dies uncleanly.
+--EXTENSIONS--
+posix
+--FILE--
+<?php
+
+$handle = popen("sleep 5; echo not visible", "r");
+
+fwrite(STDERR, "foo\n");
+posix_kill(posix_getpid(), 9);
+
+?>
+--EXPECTF--
+foo%A
+Termsig=9

run-tests.php

@@ -1209,7 +1209,7 @@ function system_with_timeout(
         $timeout *= 3;
     }
 
-    while (true) {
+    do {
         /* hide errors from interrupted syscalls */
         $r = $pipes;
         $w = null;
@@ -1225,24 +1225,20 @@ function system_with_timeout(
             /* timed out */
             $data .= "\n ** ERROR: process timed out **\n";
             proc_terminate($proc, 9);
-            return $data;
+            break;
         }
 
         if ($n > 0) {
-            if ($captureStdOut) {
+            if ($captureStdOut && in_array($pipes[1], $r)) {
                 $line = fread($pipes[1], 8192);
-            } elseif ($captureStdErr) {
+            } elseif ($captureStdErr && in_array($pipes[2], $r)) {
                 $line = fread($pipes[2], 8192);
             } else {
                 $line = '';
             }
-            if (strlen($line) == 0) {
-                /* EOF */
-                break;
-            }
             $data .= $line;
         }
-    }
+    } while (!feof($pipes[1]) || !feof($pipes[2]));
 
     $stat = proc_get_status($proc);