Test stream_context_tcp_nodelay_server on Windows

[bukka]

This is to fix stream_context_tcp_nodelay_server which currently does not have socket extension available on Windows in worker.

[cmb69]

Ah, this doesn't look like a Windows specific issue, but is more generally related to whether ext/socket is built shared or static. On Windows it's usually the former. The simplest solution would be to do what we already do regarding ext/openssl in CI:

php-src/.github/scripts/windows/test_task.bat

Lines 126 to 127 in b072206

	rem work-around for some spawned PHP processes requiring OpenSSL
	echo extension=php_openssl.dll >> %PHP_BUILD_DIR%\php.ini

Adding echo extension=php_sockets.dll >> %PHP_BUILD_DIR%\php.ini should do for now.

A more general solution would be to load ext/sockets when spawning the worker:

php-src/ext/openssl/tests/ServerClientTestCase.inc

Lines 99 to 106 in b072206

	if (defined("PHP_WINDOWS_VERSION_MAJOR")) {
	$ini = php_ini_loaded_file();
	$cmd = sprintf(
	'%s %s "%s" %s',
	PHP_BINARY, $ini ? "-n -c $ini" : "",
	__FILE__,
	WORKER_ARGV_VALUE
	);

Additionally passing -d extension=sockets if !extension_loaded("sockets") might do (unless php_sockets.dll is not available, or there are some other issues regarding php.ini).

[bukka]

Ah ok, I was actually looking to that file and completely missed that part. Thanks for pointing that out. I went for the simplest solution as it is also used for OpenSSL. It seems that extension_loaded is true in the test (there is --EXTENSIONS-- check) so it would probably require extra command to check it in the spawned process unless I'm missing something.

[andypost]

somehow it affected Alpinelinux, the test started to fail on all arches

TEST 14298/15946 [ext/standard/tests/streams/stream_context_tcp_nodelay_server.phpt]
========DIFF========
001+ 
001- server-delay:conn-nodelay
========DONE========
FAIL stream context tcp_nodelay server [ext/standard/tests/streams/stream_context_tcp_nodelay_server.phpt] 

[andypost]

ref https://gitlab.alpinelinux.org/alpine/aports/-/jobs/1763049

[andypost]

affected only 8.1.32 and 8.2.28