Skip to content

Test stream_context_tcp_nodelay_server on Windows #17308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Test stream_context_tcp_nodelay_server on Windows #17308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/scripts/windows/test_task.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ rem generate php.ini
echo extension_dir=%PHP_BUILD_DIR% > %PHP_BUILD_DIR%\php.ini
echo opcache.file_cache=%PHP_BUILD_DIR%\test_file_cache >> %PHP_BUILD_DIR%\php.ini
if "%OPCACHE%" equ "1" echo zend_extension=php_opcache.dll >> %PHP_BUILD_DIR%\php.ini
rem work-around for some spawned PHP processes requiring OpenSSL
rem work-around for some spawned PHP processes requiring OpenSSL and sockets
echo extension=php_openssl.dll >> %PHP_BUILD_DIR%\php.ini
echo extension=php_sockets.dll >> %PHP_BUILD_DIR%\php.ini

rem remove ext dlls for which tests are not supported
for %%i in (imap ldap oci8_12c pdo_firebird pdo_oci snmp) do (
Expand Down
7 changes: 2 additions & 5 deletions ext/standard/tests/streams/stream_context_tcp_nodelay_server.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ sockets
--SKIPIF--
<?php
if (!function_exists("proc_open")) die("skip no proc_open");
if (substr(PHP_OS, 0, 3) == 'WIN') {
die('skip sockets ext currently does not work in worker on Windows');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow it affected Alpinelinux, the test started to fail on all arches

TEST 14298/15946 [ext/standard/tests/streams/stream_context_tcp_nodelay_server.phpt]
========DIFF========
001+ 
001- server-delay:conn-nodelay
========DONE========
FAIL stream context tcp_nodelay server [ext/standard/tests/streams/stream_context_tcp_nodelay_server.phpt]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref https://gitlab.alpinelinux.org/alpine/aports/-/jobs/1763049

Copy link
Contributor

@andypost andypost Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

affected only 8.1.32 and 8.2.28

?>
--FILE--
<?php
Expand All @@ -32,12 +29,12 @@ CODE;

$clientCode = <<<'CODE'
$test = stream_socket_client("tcp://{{ ADDR }}", $errno, $errstr, 10);

echo phpt_wait();
CODE;

include sprintf("%s/../../../openssl/tests/ServerClientTestCase.inc", __DIR__);
ServerClientTestCase::getInstance()->run($clientCode, $serverCode);
?>
--EXPECT--
--EXPECTF--
server-delay:conn-nodelay

Loading