simplexml_import_dom() - Basic test on invalid nodetype error #6901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've submitted #6905 and it should fix the underlying issue. Please rebase when it has been merged. |
kocsismate
reviewed
Apr 23, 2021
| @@ -0,0 +1,18 @@ | |||
| --TEST-- | |||
| simplexml_import_dom() - Basic test on invalid nodetype error | |||
| --SKIPIF-- | |||
There was a problem hiding this comment.
You should use the EXTENSIONS section: #6787
There was a problem hiding this comment.
I like this change. I'll be delighted to.
| var_dump(simplexml_import_dom($x)); | ||
| ?> | ||
| --EXPECTF-- | ||
| Warning: simplexml_import_dom(): Invalid Nodetype to import in %s on line %d |
There was a problem hiding this comment.
This will be an exception after my changes, and the arginfo/zpp mismatch will be gone from debug builds.
There was a problem hiding this comment.
You can now rebase on PHP-8.0, my fix has been merged
|
Will create new PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.