Skip to content

Fix arginfo/ZPP mismatch for simplexml_import_dom #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix arginfo/ZPP mismatch for simplexml_import_dom #6905

wants to merge 3 commits into from

Conversation

kocsismate
Copy link
Member

No description provided.

nikic
nikic reviewed Apr 23, 2021
View reviewed changes
@kocsismate
Copy link
Member Author

I dug into the code a little bit more, and I've noticed that SimpleXMLElement should also accepted, so I corrected the parameter type in the stub.

@kocsismate kocsismate force-pushed the simplexml_import_dom-zpp branch from 4a87955 to 4ef341d Compare April 23, 2021 20:25
@kocsismate kocsismate mentioned this pull request Apr 23, 2021
Closed
@kocsismate kocsismate deleted the simplexml_import_dom-zpp branch April 26, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @nikic