Expose libsodium's Ristretto255 API #6922

paragonie-security · 2021-04-28T08:05:34Z

nikic

This looks reasonable, and has been accepted in the PECL ext. Main question from my side is what's up with the constants.

It also looks like some of the added APIs don't have any test coverage, for example sodium_crypto_core_ristretto255_scalar_complement.

nikic · 2021-05-06T10:29:51Z

ext/sodium/libsodium.c

+						   crypto_core_ristretto255_SCALARBYTES, CONST_CS | CONST_PERSISTENT);
+	REGISTER_LONG_CONSTANT("SODIUM_CRYPTO_CORE_RISTRETTO255_NONREDUCEDSCALARBYTES",
+						   crypto_core_ristretto255_NONREDUCEDSCALARBYTES, CONST_CS | CONST_PERSISTENT);
+#endif


Is there any reason why you omitted these constants in jedisct1/libsodium-php#212, but included them here?

Minor oversight when working with the other codebase. Will follow-up with the PECL repository before the next PECL release.

nikic · 2021-05-06T10:33:30Z

ext/sodium/libsodium.c

+	if (crypto_core_ristretto255_is_valid_point(s) != 1) {
+		RETURN_FALSE;
+	}
+	RETURN_TRUE;


Style nit:

Suggested change

if (crypto_core_ristretto255_is_valid_point(s) != 1) {

RETURN_FALSE;

}

RETURN_TRUE;

RETURN_BOOL(crypto_core_ristretto255_is_valid_point(s));

nikic · 2021-05-06T10:33:47Z

ext/sodium/libsodium.c

+		RETURN_THROWS();
+	}
+	r = zend_string_alloc(crypto_core_ristretto255_BYTES, 0);
+    crypto_core_ristretto255_random((unsigned char *) ZSTR_VAL(r));


Indent is off here.

nikic · 2021-05-06T10:38:53Z

ext/sodium/libsodium.stub.php

+
+function sodium_crypto_core_ristretto255_random(): string {}
+
+function sodium_crypto_core_ristretto255_scalar_add(string $p, string $q): string {}


The documentation at https://doc.libsodium.org/advanced/point-arithmetic/ristretto seems to use $x, $y for the scalar APIs and $p, $q for the non-scalar ones.

Good catch, I will correct this.

nikic · 2021-05-07T13:42:00Z

(An entry in UPGRADING for the new APIs would be great as well.)

Also includes the UPGRADING changes for php#6868

This is compatible with the new ext/sodium functions landing in PHP 8.1.0 and PECL libsodium 2.0.25. See: php/php-src#6922 See: jedisct1/libsodium-php#212

Includes unit tests. Refs: * https://www.php.net/manual/en/migration81.new-functions.php#migration81.new-functions.sodium * php/php-src#6868 * php/php-src@f7f1f7f * php/php-src#6922 * php/php-src@9b794f8

While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium ristretto255* functions, does declare a number of new constants as well... Includes unit tests. Refs: * php/php-src#6922 * php/php-src@9b794f8#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR368-R381

While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium xchacha* functions, does declare a couple of new constants as well... Refs: * php/php-src#6868 * php/php-src@f7f1f7f#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR352-R357 While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium ristretto255* functions, also declares a number of new constants as well... Refs: * php/php-src#6922 * php/php-src@9b794f8#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR368-R381

* PHP 8.1 | MigrationGuide/New constants: add missing constants [1] > * Added CURLOPT_DOH_URL option > * Added certificate blob options when for libcurl >= 7.71.0: > > CURLOPT_ISSUERCERT_BLOB > CURLOPT_PROXY_ISSUERCERT > CURLOPT_PROXY_ISSUERCERT_BLOB > CURLOPT_PROXY_SSLCERT_BLOB > CURLOPT_PROXY_SSLKEY_BLOB > CURLOPT_SSLCERT_BLOB > CURLOPT_SSLKEY_BLOB Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L220-L229 * php/php-src#6612 * php/php-src@3dad63b * php/php-src#7194 * php/php-src@b11785c * PHP 8.1 | MigrationGuide/New constants: add missing constants [2] > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. While not mentioned in the changelog entry, the commit to PHP does contain a new constant declaration... Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36#diff-00d1efef2247b288c86a6c3bfefac111a4774fbc5453fdc02dcf36c4a23da283R373 > GD: > * `imagewebp()` can do lossless WebP encoding by passing `IMG_WEBP_LOSSLESS` as > quality. This constant is only defined, if a libgd is used which supports > lossless WebP encoding. Refs: * https://github.com/php/php-src/blob/3a71fcf5caf042a4ce8a586a6b554fd70432e1e2/UPGRADING#L568-L571 * php/php-src#7348 * php/php-src@eb6c9eb * PHP 8.1 | MigrationGuide/New constants: add missing constants [3] > Added `POSIX_RLIMIT_KQUEUES` and `POSIX_RLIMIT_NPTS`. These rlimits are only available on FreeBSD. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.posix * php/php-src#6608 * php/php-src@ebca8de * PHP 8.1 | MigrationGuide/New constants: add missing constants [4] Refs: * https://wiki.php.net/rfc/readonly_properties_v2 * php/php-src#7089 * php/php-src@6780aaa * PHP 8.1 | MigrationGuide/New constants: add missing constants [5] While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium xchacha* functions, does declare a couple of new constants as well... Refs: * php/php-src#6868 * php/php-src@f7f1f7f#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR352-R357 While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium ristretto255* functions, also declares a number of new constants as well... Refs: * php/php-src#6922 * php/php-src@9b794f8#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR368-R381 Co-authored-by: jrfnl <[email protected]> Closes GH-1449.

* PHP 8.1 | MigrationGuide/New constants: add missing constants [1] > * Added CURLOPT_DOH_URL option > * Added certificate blob options when for libcurl >= 7.71.0: > > CURLOPT_ISSUERCERT_BLOB > CURLOPT_PROXY_ISSUERCERT > CURLOPT_PROXY_ISSUERCERT_BLOB > CURLOPT_PROXY_SSLCERT_BLOB > CURLOPT_PROXY_SSLKEY_BLOB > CURLOPT_SSLCERT_BLOB > CURLOPT_SSLKEY_BLOB Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L220-L229 * php/php-src#6612 * php/php-src@3dad63b * php/php-src#7194 * php/php-src@b11785c * PHP 8.1 | MigrationGuide/New constants: add missing constants [2] > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. While not mentioned in the changelog entry, the commit to PHP does contain a new constant declaration... Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36#diff-00d1efef2247b288c86a6c3bfefac111a4774fbc5453fdc02dcf36c4a23da283R373 > GD: > * `imagewebp()` can do lossless WebP encoding by passing `IMG_WEBP_LOSSLESS` as > quality. This constant is only defined, if a libgd is used which supports > lossless WebP encoding. Refs: * https://github.com/php/php-src/blob/3a71fcf5caf042a4ce8a586a6b554fd70432e1e2/UPGRADING#L568-L571 * php/php-src#7348 * php/php-src@eb6c9eb * PHP 8.1 | MigrationGuide/New constants: add missing constants [3] > Added `POSIX_RLIMIT_KQUEUES` and `POSIX_RLIMIT_NPTS`. These rlimits are only available on FreeBSD. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.posix * php/php-src#6608 * php/php-src@ebca8de * PHP 8.1 | MigrationGuide/New constants: add missing constants [4] Refs: * https://wiki.php.net/rfc/readonly_properties_v2 * php/php-src#7089 * php/php-src@6780aaa * PHP 8.1 | MigrationGuide/New constants: add missing constants [5] While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium xchacha* functions, does declare a couple of new constants as well... Refs: * php/php-src#6868 * php/php-src@f7f1f7f#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR352-R357 While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium ristretto255* functions, also declares a number of new constants as well... Refs: * php/php-src#6922 * php/php-src@9b794f8#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR368-R381 Co-authored-by: jrfnl <[email protected]> Closes phpGH-1449.

paragonie-security force-pushed the ristretto255 branch 2 times, most recently from dad3abd to 3a2649b Compare April 28, 2021 22:52

paragonie-security mentioned this pull request Apr 28, 2021

Add ristretto255, fix build failure with xchacha20 jedisct1/libsodium-php#212

Merged

Expose libsodium's Ristretto255 API

fbcb295

paragonie-security force-pushed the ristretto255 branch from 3a2649b to fbcb295 Compare April 29, 2021 01:03

paragonie-security marked this pull request as ready for review April 29, 2021 02:08

nikic reviewed May 6, 2021

View reviewed changes

ramsey added the Feature label May 7, 2021

paragonie-security added 2 commits May 7, 2021 16:53

Update UPGRADING to document sodium changes

1ada95d

Also includes the UPGRADING changes for php#6868

Implement suggested changes from Nikita's code review

b7a6613

ramsey approved these changes May 7, 2021

View reviewed changes

ramsey merged commit 9b794f8 into php:master May 7, 2021

paragonie-security deleted the ristretto255 branch May 7, 2021 22:51

paragonie-security added a commit to paragonie/sodium_compat that referenced this pull request May 14, 2021

Implement Ristretto255

fcb89e3

This is compatible with the new ext/sodium functions landing in PHP 8.1.0 and PECL libsodium 2.0.25. See: php/php-src#6922 See: jedisct1/libsodium-php#212

paragonie-security mentioned this pull request May 14, 2021

Implement Ristretto255 paragonie/sodium_compat#131

Merged

paragonie-security added a commit to paragonie/sodium_compat that referenced this pull request May 14, 2021

Implement Ristretto255

cc5b2d7

This is compatible with the new ext/sodium functions landing in PHP 8.1.0 and PECL libsodium 2.0.25. See: php/php-src#6922 See: jedisct1/libsodium-php#212

jrfnl mentioned this pull request Mar 9, 2022

PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325

Merged

jrfnl mentioned this pull request Mar 11, 2022

PHP 8.1 | NewConstants: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1324

Merged

jrfnl mentioned this pull request Mar 11, 2022

PHP 8.1 | MigrationGuide/New constants: add missing constants php/doc-en#1449

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expose libsodium's Ristretto255 API #6922

Expose libsodium's Ristretto255 API #6922

Uh oh!

paragonie-security commented Apr 28, 2021

Uh oh!

nikic left a comment

Uh oh!

nikic May 6, 2021

Uh oh!

paragonie-security May 7, 2021

Uh oh!

nikic May 6, 2021

Uh oh!

nikic May 6, 2021

Uh oh!

nikic May 6, 2021

Uh oh!

paragonie-security May 7, 2021

Uh oh!

nikic commented May 7, 2021

Uh oh!

Uh oh!


		function sodium_crypto_core_ristretto255_random(): string {}

		function sodium_crypto_core_ristretto255_scalar_add(string $p, string $q): string {}

Expose libsodium's Ristretto255 API #6922

Expose libsodium's Ristretto255 API #6922

Uh oh!

Conversation

paragonie-security commented Apr 28, 2021

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

nikic May 6, 2021

Choose a reason for hiding this comment

Uh oh!

paragonie-security May 7, 2021

Choose a reason for hiding this comment

Uh oh!

nikic May 6, 2021

Choose a reason for hiding this comment

Uh oh!

nikic May 6, 2021

Choose a reason for hiding this comment

Uh oh!

nikic May 6, 2021

Choose a reason for hiding this comment

Uh oh!

paragonie-security May 7, 2021

Choose a reason for hiding this comment

Uh oh!

nikic commented May 7, 2021

Uh oh!

Uh oh!