Propagate AVIF support from libgd #7026

morsssss · 2021-05-21T14:45:49Z

The work to support AVIF in getimagesize() and imagecreatefromstring() will be done in a followup PR.

Also I realize I need some tests :)

cmb69 · 2021-05-21T15:17:53Z

Also I realize I need some tests :)

Yes, at least some basic tests should be there.

Also, please resolve the merge conflicts (might be related to Flavio's already merged PR). I'll try to add Windows and AppVeyor support over the weekend.

morsssss · 2021-05-21T15:31:42Z

Agreed - I'd bet the conflicts deal with the includes.

Looks like I now have access to resolve those; so, thanks! :)

.travis.yml

morsssss · 2021-05-21T23:19:32Z

Added a little test suite!

morsssss · 2021-05-22T01:40:40Z

Well, I imagine I'd need to do something else here to help the build include libavif - or to leave it out if it's unwanted. I'm not sure where this gets configured....

cmb69 · 2021-05-22T10:59:26Z

I have just pushed a commit that fixes the imagetype support (not the real AVIF detection, though). I think that AppVeyor CI will now pass. Please pull that commit.

To get the other CIs green, just remove the attempt to install libavif (and the --with-avif) from all CIs which don't support it (probably all except for Cirrus).

cmb69 · 2021-05-22T11:46:06Z

There was another failing image test, which I fixed now. I also added AVIF support for Windows; that's not yet available for AppVeyor; I'm working on that.

cmb69 · 2021-05-22T12:36:54Z

Two CIs green! \o/

I just pushed a commit which is supposed to build with AVIF support on AppVeyor.

ext/gd/tests/avif_decode_encode.phpt

To avoid possible collision with the original libgd header files, which may be installed somewhere common like /usr/local/include

We fix an accidental fall through, and the order of enum values (COUNT has to be last). We also fix the respective test case.

This is only needed as long as libavif is not part of the official dependencies. This commit should be reverted before the PR is merged.

cmb69 · 2021-05-24T17:01:24Z

@morsssss, if you rebase your branch onto master (and force push afterwards) instead of merging master into your branch, the PR would be less noisy. :)

morsssss · 2021-05-24T17:50:23Z

@morsssss, if you rebase your branch onto master (and force push afterwards) instead of merging master into your branch, the PR would be less noisy. :)

@cmb69 Yes! I'm so embarrassed. I rebased to avoid just this problem... but I failed to force push. Then I watched in horror as it told me 302 files had been modified 😭

To avoid possible collision with the original libgd header files, which may be installed somewhere common like /usr/local/include

nikic · 2021-06-08T12:53:10Z

@cmb69 Any further comments from your side?

morsssss · 2021-06-08T15:05:09Z

🎉🎉🎉

While not mentioned in the changelog entry, the commit to PHP itself does contain a new constant declaration... Related to: > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Includes unit tests. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36#diff-00d1efef2247b288c86a6c3bfefac111a4774fbc5453fdc02dcf36c4a23da283R373

> GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Includes unit tests. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36

(mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36

> GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. While not mentioned in the changelog entry, the commit to PHP does contain a new constant declaration... Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36#diff-00d1efef2247b288c86a6c3bfefac111a4774fbc5453fdc02dcf36c4a23da283R373 > GD: > * `imagewebp()` can do lossless WebP encoding by passing `IMG_WEBP_LOSSLESS` as > quality. This constant is only defined, if a libgd is used which supports > lossless WebP encoding. Refs: * https://github.com/php/php-src/blob/3a71fcf5caf042a4ce8a586a6b554fd70432e1e2/UPGRADING#L568-L571 * php/php-src#7348 * php/php-src@eb6c9eb

* PHP 8.1 | MigrationGuide/New constants: add missing constants [1] > * Added CURLOPT_DOH_URL option > * Added certificate blob options when for libcurl >= 7.71.0: > > CURLOPT_ISSUERCERT_BLOB > CURLOPT_PROXY_ISSUERCERT > CURLOPT_PROXY_ISSUERCERT_BLOB > CURLOPT_PROXY_SSLCERT_BLOB > CURLOPT_PROXY_SSLKEY_BLOB > CURLOPT_SSLCERT_BLOB > CURLOPT_SSLKEY_BLOB Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L220-L229 * php/php-src#6612 * php/php-src@3dad63b * php/php-src#7194 * php/php-src@b11785c * PHP 8.1 | MigrationGuide/New constants: add missing constants [2] > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. While not mentioned in the changelog entry, the commit to PHP does contain a new constant declaration... Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36#diff-00d1efef2247b288c86a6c3bfefac111a4774fbc5453fdc02dcf36c4a23da283R373 > GD: > * `imagewebp()` can do lossless WebP encoding by passing `IMG_WEBP_LOSSLESS` as > quality. This constant is only defined, if a libgd is used which supports > lossless WebP encoding. Refs: * https://github.com/php/php-src/blob/3a71fcf5caf042a4ce8a586a6b554fd70432e1e2/UPGRADING#L568-L571 * php/php-src#7348 * php/php-src@eb6c9eb * PHP 8.1 | MigrationGuide/New constants: add missing constants [3] > Added `POSIX_RLIMIT_KQUEUES` and `POSIX_RLIMIT_NPTS`. These rlimits are only available on FreeBSD. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.posix * php/php-src#6608 * php/php-src@ebca8de * PHP 8.1 | MigrationGuide/New constants: add missing constants [4] Refs: * https://wiki.php.net/rfc/readonly_properties_v2 * php/php-src#7089 * php/php-src@6780aaa * PHP 8.1 | MigrationGuide/New constants: add missing constants [5] While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium xchacha* functions, does declare a couple of new constants as well... Refs: * php/php-src#6868 * php/php-src@f7f1f7f#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR352-R357 While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium ristretto255* functions, also declares a number of new constants as well... Refs: * php/php-src#6922 * php/php-src@9b794f8#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR368-R381 Co-authored-by: jrfnl <[email protected]> Closes GH-1449.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <[email protected]> Closes GH-1448.

* PHP 8.1 | MigrationGuide/New constants: add missing constants [1] > * Added CURLOPT_DOH_URL option > * Added certificate blob options when for libcurl >= 7.71.0: > > CURLOPT_ISSUERCERT_BLOB > CURLOPT_PROXY_ISSUERCERT > CURLOPT_PROXY_ISSUERCERT_BLOB > CURLOPT_PROXY_SSLCERT_BLOB > CURLOPT_PROXY_SSLKEY_BLOB > CURLOPT_SSLCERT_BLOB > CURLOPT_SSLKEY_BLOB Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L220-L229 * php/php-src#6612 * php/php-src@3dad63b * php/php-src#7194 * php/php-src@b11785c * PHP 8.1 | MigrationGuide/New constants: add missing constants [2] > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. While not mentioned in the changelog entry, the commit to PHP does contain a new constant declaration... Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36#diff-00d1efef2247b288c86a6c3bfefac111a4774fbc5453fdc02dcf36c4a23da283R373 > GD: > * `imagewebp()` can do lossless WebP encoding by passing `IMG_WEBP_LOSSLESS` as > quality. This constant is only defined, if a libgd is used which supports > lossless WebP encoding. Refs: * https://github.com/php/php-src/blob/3a71fcf5caf042a4ce8a586a6b554fd70432e1e2/UPGRADING#L568-L571 * php/php-src#7348 * php/php-src@eb6c9eb * PHP 8.1 | MigrationGuide/New constants: add missing constants [3] > Added `POSIX_RLIMIT_KQUEUES` and `POSIX_RLIMIT_NPTS`. These rlimits are only available on FreeBSD. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.posix * php/php-src#6608 * php/php-src@ebca8de * PHP 8.1 | MigrationGuide/New constants: add missing constants [4] Refs: * https://wiki.php.net/rfc/readonly_properties_v2 * php/php-src#7089 * php/php-src@6780aaa * PHP 8.1 | MigrationGuide/New constants: add missing constants [5] While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium xchacha* functions, does declare a couple of new constants as well... Refs: * php/php-src#6868 * php/php-src@f7f1f7f#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR352-R357 While not mentioned anywhere at all, the commit to PHP itself adding support for the Sodium ristretto255* functions, also declares a number of new constants as well... Refs: * php/php-src#6922 * php/php-src@9b794f8#diff-3fe4027560fd299248af1dc1efe04287cc2b6418e8f01755c05c9db64b668b1eR368-R381 Co-authored-by: jrfnl <[email protected]> Closes phpGH-1449.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <[email protected]> Closes phpGH-1448.

When the avif support was first added (phpGH-7026), php-src did not use GitHub Actions. When we moved to GitHub Actions for CI, the `--with-avif` option nor the `libavif-dev` dependencies were not added. Cirrus CI still runs the tests, and now that we no longer use Travis CI, this brings parity to test avif on x64 tests on GitHub Actions as well. `libavif-dev` package's x86 builds seem to be missing[^1][^2] on older Ubuntu versions, so this commit only adds it for x64 builds. - [^1]: https://packages.ubuntu.com/jammy/libavif-dev - [^2]: https://packages.ubuntu.com/noble/libavif-dev

When the avif support was first added (phpGH-7026), php-src did not use GitHub Actions. When we moved to GitHub Actions for CI, the `--with-avif` option nor the `libavif-dev` dependencies were not added. Cirrus CI still runs the tests, and now that we no longer use Travis CI, this brings parity to test avif on x64 tests on GitHub Actions as well. `libavif-dev` package's x86 builds seem to be missing[^1][^2] on older Ubuntu versions, so this commit only adds it for x64 builds. [^1]: https://packages.ubuntu.com/jammy/libavif-dev [^2]: https://packages.ubuntu.com/noble/libavif-dev

When the avif support was first added (GH-7026), php-src did not use GitHub Actions. When we moved to GitHub Actions for CI, the `--with-avif` option nor the `libavif-dev` dependencies were not added. Cirrus CI still runs the tests, and now that we no longer use Travis CI, this brings parity to test avif on x64 tests on GitHub Actions as well. `libavif-dev` package's x86 builds seem to be missing[^1][^2] on older Ubuntu versions, so this commit only adds it for x64 builds. [^1]: https://packages.ubuntu.com/jammy/libavif-dev [^2]: https://packages.ubuntu.com/noble/libavif-dev

nikic reviewed May 21, 2021

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

cmb69 reviewed May 22, 2021

View reviewed changes

ext/gd/tests/avif_decode_encode.phpt Outdated Show resolved Hide resolved

cmb69 reviewed May 22, 2021

View reviewed changes

ext/gd/tests/avif_decode_encode.phpt Show resolved Hide resolved

morsssss and others added 13 commits May 24, 2021 11:57

Initial commit before rebase

592ac3a

Incremental commit

86a5eb0

Incremental commit

f1b3dd1

Include logic to extract speed param in _php_image_output_ctx()

acc40b9

Change gd includes to quotes instead of angle brackets

e613ec3

To avoid possible collision with the original libgd header files, which may be installed somewhere common like /usr/local/include

Change one avifFree() to gdFree()

1fad3c4

Fix includes

a077c1a

Add test script and test image

4c8790f

Use new --EXTENSIONS-- to ensure gd is available

cf9696b

Fix IMAGETYPE_AVIF support

d698aad

We fix an accidental fall through, and the order of enum values (COUNT has to be last). We also fix the respective test case.

Fix failing test case

14d6d2f

Add AVIF support for bundled GD on Windows

b9d8de8

Build GD with libavif on AppVeyor

9aa1b36

This is only needed as long as libavif is not part of the official dependencies. This commit should be reverted before the PR is merged.

morsssss added 5 commits May 24, 2021 13:55

Initial commit before rebase

0585c08

Incremental commit

5a73a40

Incremental commit

a1cb830

Change gd includes to quotes instead of angle brackets

e98f2ca

To avoid possible collision with the original libgd header files, which may be installed somewhere common like /usr/local/include

Fix includes

a6a161f

morsssss requested a review from cmb69 June 7, 2021 13:55

cmb69 approved these changes Jun 8, 2021

View reviewed changes

nikic closed this in 81f6d36 Jun 10, 2021

morsssss mentioned this pull request Jun 18, 2021

[4.0] com_media not possible to upload an avif image joomla/joomla-cms#30666

Closed

This was referenced Jun 26, 2021

Feature request: static avif libs winlibs/libavif#1

Closed

Windows: allow GD ext without avif.dll #7200

Closed

dgrammatiko mentioned this pull request Jul 3, 2021

AVIF Support Intervention/image#1056

Merged

markusguenther mentioned this pull request Jul 8, 2021

FEATURE: Allow the format avif for thumbnail generation. neos/neos-development-collection#3135

Merged

gijsdev mentioned this pull request Sep 15, 2021

GD AVIF support Intervention/image#1113

Merged

mondrake mentioned this pull request Sep 22, 2021

Support for AVIF in PHP8.1RC3 shivammathur/php-builder#12

Closed

1 task

This was referenced Mar 9, 2022

PHP 8.1 | NewConstants: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1324

Merged

PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325

Merged

This was referenced Mar 11, 2022

PHP 8.1 | MigrationGuide/New functions: add missing functions php/doc-en#1448

Merged

PHP 8.1 | MigrationGuide/New constants: add missing constants php/doc-en#1449

Merged

jnoordsij mentioned this pull request Jan 4, 2024

Add avif to gd installation instructions php/doc-en#3058

Merged

Ayesh mentioned this pull request Sep 12, 2024

ext/gd: enable avif tests on GH-Actions #15850

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Propagate AVIF support from libgd #7026

Propagate AVIF support from libgd #7026

Uh oh!

morsssss commented May 21, 2021

Uh oh!

cmb69 commented May 21, 2021

Uh oh!

morsssss commented May 21, 2021

Uh oh!

Uh oh!

morsssss commented May 21, 2021

Uh oh!

morsssss commented May 22, 2021

Uh oh!

cmb69 commented May 22, 2021

Uh oh!

cmb69 commented May 22, 2021

Uh oh!

cmb69 commented May 22, 2021

Uh oh!

Uh oh!

Uh oh!

cmb69 commented May 24, 2021

Uh oh!

morsssss commented May 24, 2021

Uh oh!

nikic commented Jun 8, 2021

Uh oh!

morsssss commented Jun 8, 2021

Uh oh!

Uh oh!

Propagate AVIF support from libgd #7026

Propagate AVIF support from libgd #7026

Uh oh!

Conversation

morsssss commented May 21, 2021

Uh oh!

cmb69 commented May 21, 2021

Uh oh!

morsssss commented May 21, 2021

Uh oh!

Uh oh!

morsssss commented May 21, 2021

Uh oh!

morsssss commented May 22, 2021

Uh oh!

cmb69 commented May 22, 2021

Uh oh!

cmb69 commented May 22, 2021

Uh oh!

cmb69 commented May 22, 2021

Uh oh!

Uh oh!

Uh oh!

cmb69 commented May 24, 2021

Uh oh!

morsssss commented May 24, 2021

Uh oh!

nikic commented Jun 8, 2021

Uh oh!

morsssss commented Jun 8, 2021

Uh oh!

Uh oh!