Make run-tests.php check for tcp fwrite edge cases #8023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Feb 3, 2022
When the recipient is busy or the payload is large, fwrite can block or return a value smaller than the length of the stream. workers in run-tests.php communicates over tcp sockets with the manager. https://cirrus-ci.com/task/5315675320221696?logs=tests#L130 showed notices for fwrite/unserialize This is a similar approach to that used in https://github.com/phan/phan/blob/v5/src/Phan/LanguageServer/ProtocolStreamWriter.php for the tcp language server writing.
TysonAndre
force-pushed
the
run-tests-fwrite-error
branch
from
b4d37fa to
a9c21db
Compare
iluuu1994
reviewed
Mar 24, 2022
| function send_message($stream, array $message): void | ||
| { | ||
| $blocking = stream_get_meta_data($stream)["blocked"]; | ||
| stream_set_blocking($stream, true); | ||
| fwrite($stream, base64_encode(serialize($message)) . "\n"); | ||
| safe_fwrite($stream, base64_encode(serialize($message)) . "\n"); |
There was a problem hiding this comment.
Unused return value, should something happen if a write fails?
| echo "ERROR: send_message() Failed to write chunk after 10 retries: " . error_get_last()['message'] . "\n"; | ||
| return false; | ||
| } | ||
| $writeSockets = [$stream]; |
| // safe_fwrite was tested by adding $message['unused'] = str_repeat('a', 20_000_000); in send_message() | ||
| // fwrites on tcp sockets can return false or less than strlen if the recipient is busy. | ||
| // (e.g. fwrite(): Send of 577 bytes failed with errno=35 Resource temporarily unavailable) | ||
| $bytesWritten = 0; |
There was a problem hiding this comment.
The rest of this file uses snake_case
|
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the recipient is busy or the payload is large, fwrite can block
or return a value smaller than the length of the stream.
workers in run-tests.php communicate over tcp sockets with the manager.
https://cirrus-ci.com/task/5315675320221696?logs=tests#L130
showed notices for fwrite/unserialize
This is a similar approach to that used in
https://github.com/phan/phan/blob/v5/src/Phan/LanguageServer/ProtocolStreamWriter.php
for the tcp language server writing.