Skip to content

Make run-tests.php check for tcp fwrite edge cases #8023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion run-tests.php
Original file line number Diff line number Diff line change
Expand Up @@ -1729,11 +1729,46 @@ function run_all_tests_parallel(array $test_files, array $env, $redir_tested): v
}
}

/**
* Calls fwrite and retries when network writes fail with errors such as "Resource temporarily unavailable"
*
* @param resource $stream the stream to fwrite to
* @param string $data
* @return int|false
*/
function safe_fwrite($stream, string $data)
{
// safe_fwrite was tested by adding $message['unused'] = str_repeat('a', 20_000_000); in send_message()
// fwrites on tcp sockets can return false or less than strlen if the recipient is busy.
// (e.g. fwrite(): Send of 577 bytes failed with errno=35 Resource temporarily unavailable)
$bytesWritten = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of this file uses snake_case

$retryAttempts = 0;
while ($bytesWritten < strlen($data)) {
$n = @fwrite($stream, substr($data, $bytesWritten));
if ($n === false) {
if ($retryAttempts >= 10) {
echo "ERROR: send_message() Failed to write chunk after 10 retries: " . error_get_last()['message'] . "\n";
return false;
}
$writeSockets = [$stream];
Copy link
Member

@iluuu1994 iluuu1994 Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$write_streams?

$readSockets = [];
$exceptSockets = [];
/* Wait for a second and retry up to 10 times. Use a finite timeout and retry count in case stream_select returns inaccurate values or returns immediately. */
stream_select($readSockets, $writeSockets, $exceptSockets, 1);
$retryAttempts++;
continue;
}
$bytesWritten += $n;
$retryAttempts = 0;
}
return $bytesWritten;
}

function send_message($stream, array $message): void
{
$blocking = stream_get_meta_data($stream)["blocked"];
stream_set_blocking($stream, true);
fwrite($stream, base64_encode(serialize($message)) . "\n");
safe_fwrite($stream, base64_encode(serialize($message)) . "\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused return value, should something happen if a write fails?

stream_set_blocking($stream, $blocking);
}

Expand Down