Fixed bug #68128

[datibbaw]

Fixes an issue that's been around since d81ea16.

Three issues are addressed:

1. RecursiveRegexIterator::accept() should accept non-empty arrays without applying any regular expression and RegexIterator::accept() should not accept an array.
2. RegexIterator::accept() should not accept an atom that fails to match anything, even when PREG_PATTERN_ORDER is used (which would return an array of empty arrays).
3. RecursiveRegexIterator::getChildren() should pass all constructor arguments to its child iterator instead of just the regular expression.

[Hywan]

👍

[Hywan]

How to fix this in prior PHP versions (by extending the RecursiveRegexIterator class)?

[datibbaw]

@Hywan When you extend RecursiveRegexIterator, the following ::accept() implementation should do the trick:

function accept()
{
    return $this->hasChildren() || parent::accept();
}

[datibbaw]

@Hywan This patch can easily be back ported to earlier versions.

[Hywan]

@datibbaw Exactly, it fixes the issue and tests are green again. Thanks!

[Hywan]

Now, HHVM has the same bug…

[SiebelsTim]

cc @SiebelsTim

[datibbaw]

I've asked the list to review the code changes; if all is well, it will be merged by the end of this week.

[Hywan]

Is the documentation need to be updated?

[datibbaw]

@Hywan Could you log a separate Doc bug for that? The PCRE constants are declared on RegexIterator, so ideally it should be documented in that way.

[Hywan]

@datibbaw On Github or on edit.php.net?

[JoelMarcey]

What are the chances that this pull request will be accepted? And, if it is, in what PHP versions would the fix be incorporated? Thanks.

[datibbaw]

@Tyrael ping! do you reckon this should be back ported to 5.6?

[Tyrael]

@datibbaw I would be fine having it in 5.6

[datibbaw]

PHP-5.5: 71ba533
PHP-5.6: fb35d7c
master: 1f4f2ef

[marcioAlmada]

@datibbaw I'm sorry to necromance your pull request 😅 but there is a sequel here #2133 you may want to review and voice an opinion.