Skip to content

Fix GH-9769: Improve error message for array unpacking in constant expression #9776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix GH-9769: Improve error message for array unpacking in constant expression #9776

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2d4b81
Only arrays can be unpacked in constant expression
jhdxr Oct 18, 2022
6ed7e6e
remove outdated comment
jhdxr Oct 18, 2022
b7bbddd
add test
jhdxr Nov 16, 2022
9e403fe
add new line at EOF
jhdxr Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zend/zend_ast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ static zend_result zend_ast_add_unpacked_element(zval *result, zval *expr) {
}

/* Objects or references cannot occur in a constant expression. */
zend_throw_error(NULL, "Only arrays and Traversables can be unpacked");
zend_throw_error(NULL, "Only arrays can be unpacked in constant expression");
return FAILURE;
}

Expand Down