-
Notifications
You must be signed in to change notification settings - Fork 25
Post-v0.0.1 Fixes - Release v0.0.2 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@plotly/dash-core Wanted to have your thoughts on the But the components built with the boilerplate seems to also publish a bunch of irrelevant files when I run Should we just manually add all the files to npmignore, or would it be better to use some "include" scripts (similar to manifest.in)? |
Yes update |
.npmignore
Outdated
.circleci | ||
.vscode | ||
.github | ||
dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dist should be part of the npm package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does dist/
contain any .js
file? I was under the impression only the generated wheels goes there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does dist
contain any JS file? I thought only the wheels go there (might be wrong)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, might be a better idea to use the files
field: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't want to ignore the js files that should be part of the npm package. no need to add then in package.json in files.
@jourdain Just realized the |
Making this PR to add a few things I noticed were missing. Will be shipped in v0.0.2