Skip to content

Post-v0.0.1 Fixes - Release v0.0.2 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ config
.travis.yml
CHANGELOG.md
README.md

*venv
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: dashVtk
Title: React based declarative usage of vtk.js for Dash
Version: 0.0.1
Version: 0.0.2
Description: React based declarative usage of vtk.js for Dash
Depends: R (>= 3.0.2)
Imports:
Expand Down
4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@

name = "DashVtk"
uuid = "1b08a953-4be3-4667-9a23-818b1eccd4c7"
authors = ["Kitware Inc <[email protected]>"]
version = "0.0.1"
authors = ["Kitware Inc <[email protected]> and Plotly Technologies <[email protected]>"]
version = "0.0.2"

[deps]
Dash = "1b08a953-4be3-4667-9a23-3db579824955"
Expand Down
4 changes: 2 additions & 2 deletions R/internal.R
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
.dashVtk_js_metadata <- function() {
deps_metadata <- list(`dash_vtk` = structure(list(name = "dash_vtk",
version = "0.0.1", src = list(href = NULL,
version = "0.0.2", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_vtk.min.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashVtk",
all_files = FALSE), class = "html_dependency"),
`dash_vtk` = structure(list(name = "dash_vtk",
version = "0.0.1", src = list(href = NULL,
version = "0.0.2", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_vtk.min.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashVtk",
Expand Down
15 changes: 11 additions & 4 deletions dash_vtk/package-info.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash_vtk",
"version": "0.0.1",
"version": "0.0.2",
"description": "React based declarative usage of vtk.js for Dash",
"repository": {
"type": "git",
Expand All @@ -21,7 +21,7 @@
"build": "npm run build:js && npm run build:py_and_r",
"build:activated": "npm run build:js && npm run build:py_and_r-activated"
},
"author": "Kitware Inc <[email protected]>",
"author": "Kitware Inc <[email protected]> and Plotly Technologies <[email protected]>",
"license": "MIT",
"dependencies": {
"ramda": "^0.26.1",
Expand Down Expand Up @@ -54,5 +54,12 @@
"engines": {
"node": ">=8.11.0",
"npm": ">=6.1.0"
}
}
},
"files": [
"dash_vtk",
"src",
"README.md",
"docs",
"dist"
]
}
16 changes: 15 additions & 1 deletion docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.0.1] - 2021-01-??
## [0.0.2] - 2021-01-29

### Added

* PyPi description auto-generated from `README.md`

### Changed
* Use `package.json`'s files instead of `npmignore`
* Change order of instructions in `docs/CONTRIBUTING.md`

### Fixed
* Update `setup.py` to include `utils` directory when upload to PyPi.


## [0.0.1] - 2021-01-29

This is the initial release.
23 changes: 12 additions & 11 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,30 +115,31 @@ python setup.py sdist
```
6. Copy the tarball into a separate folder and try to install it and run the examples:
```
cp dist/dash_vtk-x.x.x.tar.gz ../temp
cp usage.py ../temp
cd ../temp
source venv/bin/activate
pip install dash_vtk-x.x.x.tar.gz
virtualenv venv-release
source venv-release/bin/activate
pip install dist/dash_vtk-x.x.x.tar.gz
python usage.py
rm -r venv-release/ # Clean up after you are done
```
7. If the examples work, then publish:
```
npm login # only if you are not already logged in
npm publish
twine upload dist/dash_vtk-x.x.x.tar.gz
```
8. Tag your release with git:
```
git tag -a 'vx.x.x' -m 'vx.x.x'
git push origin master --follow-tags
```
9. Verify that the publish worked by installing it:

8. Verify that the publish worked by installing it:
```
cd ../temp
pip install dash-vtk==x.x.x
python usage.py
```

9. Tag your release with git:
```
git tag -a 'vx.x.x' -m 'vx.x.x'
git push origin master --follow-tags
```

Make a post in the [Dash Community Forum](https://community.plotly.com/c/dash)
* Title it `":mega: Announcement! New <Your Feature> - Feedback Welcome"`
Expand Down
15 changes: 11 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash_vtk",
"version": "0.0.1",
"version": "0.0.2",
"description": "React based declarative usage of vtk.js for Dash",
"repository": {
"type": "git",
Expand All @@ -21,7 +21,7 @@
"build": "npm run build:js && npm run build:py_and_r",
"build:activated": "npm run build:js && npm run build:py_and_r-activated"
},
"author": "Kitware Inc <[email protected]>",
"author": "Kitware Inc <[email protected]> and Plotly Technologies <[email protected]>",
"license": "MIT",
"dependencies": {
"ramda": "^0.26.1",
Expand Down Expand Up @@ -54,5 +54,12 @@
"engines": {
"node": ">=8.11.0",
"npm": ">=6.1.0"
}
}
},
"files": [
"dash_vtk",
"src",
"README.md",
"docs",
"dist"
]
}
8 changes: 6 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import io
import json
import os
from setuptools import setup
from setuptools import setup, find_packages


with open('package.json') as f:
Expand All @@ -12,10 +13,13 @@
name=package_name,
version=package["version"],
author=package['author'],
packages=[package_name],
packages=find_packages(include=[package_name, package_name + ".*"]),
include_package_data=True,
license=package['license'],
description=package.get('description', package_name),
long_description=io.open('README.md', encoding='utf-8').read(),
long_description_content_type='text/markdown',
url='https://github.com/plotly/dash-vtk',
install_requires=['dash'],
classifiers=[
'Environment :: Web Environment',
Expand Down
6 changes: 3 additions & 3 deletions src/DashVtk.jl
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module DashVtk
using Dash

const resources_path = realpath(joinpath( @__DIR__, "..", "deps"))
const version = "0.0.1"
const version = "0.0.2"

include("vtk_algorithm.jl")
include("vtk_calculator.jl")
Expand Down Expand Up @@ -34,14 +34,14 @@ function __init__()
[
DashBase.Resource(
relative_package_path = "dash_vtk.min.js",
external_url = "https://unpkg.com/[email protected].1/dash_vtk/dash_vtk.min.js",
external_url = "https://unpkg.com/[email protected].2/dash_vtk/dash_vtk.min.js",
dynamic = nothing,
async = nothing,
type = :js
),
DashBase.Resource(
relative_package_path = "dash_vtk.min.js.map",
external_url = "https://unpkg.com/[email protected].1/dash_vtk/dash_vtk.min.js.map",
external_url = "https://unpkg.com/[email protected].2/dash_vtk/dash_vtk.min.js.map",
dynamic = true,
async = nothing,
type = :js
Expand Down