-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Adds createFilterShader() and custom shader support to the webGL filter() function #6237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
16def01
declare framebuffer usage
wong-justin c7abb8c
new properties for shader filters
wong-justin 9dbe595
partial shader filter implementation instead of error
wong-justin a096914
add new filter() signature
wong-justin 87f347a
branch filter() for either webgl mode or 2d mode, not just 2d
wong-justin e0126bf
revert to p5.Graphics instead of p5.Framebuffer, at least for now
wong-justin cb1979b
apply shader to secondary graphics, then draw onto main
wong-justin 644e61a
Merge remote-tracking branch 'upstream/main' into shader-filters
wong-justin 628fc18
add manual test for webgl filter()
wong-justin 359d16b
add some automated webgl filter tests
wong-justin e857d5b
remove confused arguments
wong-justin a762869
create new shader bound to secondary graphics
wong-justin 2eb64a0
add tests to check sizing
wong-justin 0c5d0ff
docs for filter(shader)
wong-justin 10d85ff
add resizing to secondary graphics
wong-justin f324437
only create secondary shader once
wong-justin 7f39f69
leave out filter(CONSTANT) test until that feature is added
wong-justin fc50e52
remove resolution check because pixel density wont change
wong-justin f3a41e7
remove framebuffer test since framebuffer isnt used for now
wong-justin 7888ad4
fill in empty tests
wong-justin b52a467
wip: copy uniforms to shader copy
wong-justin 02113bb
add performance visual to filter test page
wong-justin be7c01c
Merge remote-tracking branch 'upstream/main' into shader-filters
wong-justin aa1f048
expose the built library
wong-justin 5d50053
rebuild p5.min.js
wong-justin 4e52976
add non-minified library too
wong-justin 590d025
fix parent shader check
wong-justin f2e69ae
remove tabs and console.log
wong-justin 6e4c04e
add createFilterShader that includes default vertex shader
wong-justin f23d072
update output lib
wong-justin 034ebb5
clean whitespace
wong-justin 7bfa2f2
stop tracking output libs
wong-justin f6fbdc2
test for createFilterShader()
wong-justin 86cb79d
mark todos for next PR
wong-justin bf282f3
fix gitignore
wong-justin 25424c7
document uniforms
wong-justin d1dd620
refine example fragment shaders
wong-justin fa178ba
default vertex shader
wong-justin 68ad8ae
rest of createFilterShader docs
wong-justin c039991
adjust test shaders to match default filter shaders
wong-justin c476759
add test comparing default vertex shader to a supplied one
wong-justin 4b1e56e
revert pre-flipping the y in the vertex shader
wong-justin ec76701
add test for edge case of filter shader on graphics context
wong-justin 8220071
move uniform documentation to setUniform
wong-justin 44ad94f
add disclaimers to createFilterShader docs
wong-justin a532146
Merge remote-tracking branch 'upstream/main' into shader-filters
wong-justin 479aca3
go back to flipping the y
wong-justin 4250399
fix filter() not working on a secondary p5.Graphics
wong-justin 5abd47d
small wording changes in createFilterShader docs
wong-justin 51aa874
remove unused commented code from test
wong-justin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.